Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Origin Tags to cycle group #9879

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

Rumata888
Copy link
Contributor

Adds Origin Tag support (mechanism for tracking dangerous interactions of stdlib primitives) to cycle_group

@Rumata888 Rumata888 added the product-security PRs extending our security mechanisms label Nov 11, 2024
@Rumata888 Rumata888 self-assigned this Nov 11, 2024
Copy link
Contributor

@Sarkoxed Sarkoxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that one typo

EXPECT_EQ(standard_c.is_point_at_infinity().get_value(), false);
EXPECT_EQ(standard_d.is_point_at_infinity().get_value(), true);

// Ensure that the tags in the standard from remain the same
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: form

Copy link
Contributor

@Sarkoxed Sarkoxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rumata888 Rumata888 merged commit de6564e into master Nov 12, 2024
47 of 48 checks passed
@Rumata888 Rumata888 deleted the is/origin_tags_part_4 branch November 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product-security PRs extending our security mechanisms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants