From f40b896ae493b77a3b3358cfee7f4e39757e5c8a Mon Sep 17 00:00:00 2001
From: guipublic <guipublic@gmail.com>
Date: Wed, 28 Aug 2024 16:21:16 +0000
Subject: [PATCH] handle constant output for sha256

---
 .../dsl/acir_format/sha256_constraint.cpp     | 35 ++++++++++++-------
 1 file changed, 23 insertions(+), 12 deletions(-)

diff --git a/barretenberg/cpp/src/barretenberg/dsl/acir_format/sha256_constraint.cpp b/barretenberg/cpp/src/barretenberg/dsl/acir_format/sha256_constraint.cpp
index 99f88882937..cafec218b11 100644
--- a/barretenberg/cpp/src/barretenberg/dsl/acir_format/sha256_constraint.cpp
+++ b/barretenberg/cpp/src/barretenberg/dsl/acir_format/sha256_constraint.cpp
@@ -1,6 +1,7 @@
 #include "sha256_constraint.hpp"
 #include "barretenberg/stdlib/hash/sha256/sha256.hpp"
 #include "barretenberg/stdlib/hash/sha256/sha256_plookup.hpp"
+#include "msgpack/v3/unpack_decl.hpp"
 #include "round.hpp"
 
 namespace acir_format {
@@ -39,7 +40,12 @@ template <typename Builder> void create_sha256_constraints(Builder& builder, con
     auto bytes = output_bytes.bytes();
 
     for (size_t i = 0; i < bytes.size(); ++i) {
-        builder.assert_equal(bytes[i].normalize().witness_index, constraint.result[i]);
+        auto normalised = bytes[i].normalize();
+        if (normalised.is_constant()) {
+            builder.fix_witness(constraint.result[i], normalised.get_value());
+        } else {
+            builder.assert_equal(bytes[i].normalize().witness_index, constraint.result[i]);
+        }
     }
 }
 
@@ -69,17 +75,22 @@ void create_sha256_compression_constraints(Builder& builder, const Sha256Compres
     auto output_bytes = stdlib::sha256_plookup::sha256_block<Builder>(hash_inputs, inputs);
 
     for (size_t i = 0; i < 8; ++i) {
-        poly_triple assert_equal{
-            .a = output_bytes[i].normalize().witness_index,
-            .b = constraint.result[i],
-            .c = 0,
-            .q_m = 0,
-            .q_l = 1,
-            .q_r = -1,
-            .q_o = 0,
-            .q_c = 0,
-        };
-        builder.create_poly_gate(assert_equal);
+        auto normalised_output = output_bytes[i].normalize();
+        if (normalised_output.is_constant()) {
+            builder.fix_witness(constraint.result[i], normalised_output.get_value());
+        } else {
+            poly_triple assert_equal{
+                .a = normalised_output.witness_index,
+                .b = constraint.result[i],
+                .c = 0,
+                .q_m = 0,
+                .q_l = 1,
+                .q_r = -1,
+                .q_o = 0,
+                .q_c = 0,
+            };
+            builder.create_poly_gate(assert_equal);
+        }
     }
 }