diff --git a/noir-projects/aztec-nr/aztec/src/encrypted_logs/incoming_body.nr b/noir-projects/aztec-nr/aztec/src/encrypted_logs/incoming_body.nr index 84077a2defb..fd2cab4422e 100644 --- a/noir-projects/aztec-nr/aztec/src/encrypted_logs/incoming_body.nr +++ b/noir-projects/aztec-nr/aztec/src/encrypted_logs/incoming_body.nr @@ -59,7 +59,7 @@ mod test { global ADDRESS_NOTE_BYTES_LEN = 32 * 3 + 64; impl NoteInterface for AddressNote { - fn compute_note_hiding_point(self) -> Point { + fn compute_note_hiding_point(_self: Self) -> Point { crate::generators::Ga1 } diff --git a/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_reset.nr b/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_reset.nr index e64fb83cbde..1b1ae044ca0 100644 --- a/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_reset.nr +++ b/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_reset.nr @@ -31,9 +31,9 @@ struct PrivateKernelResetCircuitPrivateInputs u8 { // Since we cannot isolate branches, it doesn't cost fewer gates than using // MerkleTree on the full array of elements N, but is slightly cheaper on-chain // and cleaner elsewhere. -impl VariableMerkleTree { +impl VariableMerkleTree { // Example - tx_0 with 3 msgs | tx_1 with 2 msgs creates: - // + // // tx0oh tx1oh - // / \ / \ + // / \ / \ // msg01 msg23 msg3 msg4 - // / \ / \ - // msg0 msg1 msg2 0 + // / \ / \ + // msg0 msg1 msg2 0 // | tx_0 | | tx_1 | // - pub fn new_sha(leaves: [Field; N], num_non_empty_leaves: u32) -> Self { + pub fn new_sha(leaves: [Field; N], num_non_empty_leaves: u32) -> Self { // Find size of tree required let height = get_height(num_non_empty_leaves, 0); let next_power_2 = 2 << height; diff --git a/noir-projects/noir-protocol-circuits/crates/types/src/utils/arrays/assert_combined_deduped_array/assert_deduped_array.nr b/noir-projects/noir-protocol-circuits/crates/types/src/utils/arrays/assert_combined_deduped_array/assert_deduped_array.nr index c58e0f66b83..c0fb2c0ea77 100644 --- a/noir-projects/noir-protocol-circuits/crates/types/src/utils/arrays/assert_combined_deduped_array/assert_deduped_array.nr +++ b/noir-projects/noir-protocol-circuits/crates/types/src/utils/arrays/assert_combined_deduped_array/assert_deduped_array.nr @@ -2,7 +2,7 @@ use crate::{abis::side_effect::{Positioned, Ordered}, traits::Empty, utils::arra /* The sorted_array here needs to be sorted based on the `position` field of the container, - *and* a secondary sort based on the `counter` field of the container. + *and* a secondary sort based on the `counter` field of the container. For example, the storage slot in the case of public data update requests. The run_lengths array should contain the length of each run of the sorted_array. @@ -25,13 +25,13 @@ use crate::{abis::side_effect::{Positioned, Ordered}, traits::Empty, utils::arra then the deduped_array should be: [ (1,2,4), (2,3,3), (3,6,6), (4,8,9), (5,9,7), (0,0,0), ... padding with zeros ] */ -pub fn assert_deduped_array( +pub fn assert_deduped_array( sorted_array: [T; N], deduped_array: [T; N], run_lengths: [u32; N] ) where T: Positioned + Ordered + Empty + Eq { let num_non_empty_items = array_length(sorted_array); - let deduped_len = validate_array(deduped_array); // This makes sure that the array is padded with empty items. + let deduped_len = validate_array(deduped_array); // This makes sure that the array is padded with empty items. // container at the start of the current run let mut start_run_container = sorted_array[0];