Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashType and CommitmentType specification #426

Open
codygunton opened this issue May 4, 2023 · 0 comments
Open

HashType and CommitmentType specification #426

codygunton opened this issue May 4, 2023 · 0 comments

Comments

@codygunton
Copy link
Collaborator

codygunton commented May 4, 2023

We have lines like

static constexpr merkle::HashType merkle_hash_type = merkle::HashType::LOOKUP_PEDERSEN;
static constexpr pedersen::CommitmentType commitment_type = pedersen::CommitmentType::FIXED_BASE_PEDERSEN;

in the circuit builders, and there is a question of where this sort of data actually belongs. Should it go in the flavor? My hunch is that it's probably better not to attach this choice once and for all to a proving system, but to select the type on a per-application basis. Someone should dig in and figure out the proper place of this (maybe it is actually Aztec-specific and shouldn't be in Barretenberg at all?). Perhaps this can go away altogether with the introduction of the one true Pedersen hash in #671?

@codygunton codygunton mentioned this issue May 4, 2023
11 tasks
@codygunton codygunton changed the title HashType and CommitmentType specification HashType and CommitmentType specification Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant