Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog capturing of PRs from _AztecProtocol/aztec-packages_ #716

Open
Savio-Sou opened this issue Sep 4, 2023 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Savio-Sou
Copy link
Member

Context

Barretenberg releases currently captures PRs into their changelogs assuming PR numbers all belong to this repo.

Problem

This works as expected with PRs created in this repo.

But when PRs are mirrored from AztecProtocol/aztec-packages, the release changelogs would be linking to https://github.com/AztecProtocol/barretenberg/<aztec-packages_PR_number>, which points to unrelated / non-existing PRs in this repo.

Example

Take v0.5.0 as an example:

Clicking "#1925" of "update to acvm 0.24.0" would link to AztecProtocol/barretenberg/issues/1925, rather than the actual PR AztecProtocol/aztec-packages/pull/1925.

Happy Case

Either the release-please or mirroring workflow should be fixed to cater for capturing mirrored PRs in changelogs appropriately.

@Savio-Sou Savio-Sou added bug Something isn't working good first issue Good for newcomers labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant