Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json file loading to use loadJsonContent #343

Merged
merged 7 commits into from
Oct 20, 2022

Conversation

KevinRabun
Copy link
Contributor

Overview/Summary

Updated json file loading to use loadJsonContent instead of json(loadTextContent. This approach allows for roughly 8x larger json files to be loaded by Bicep.

This PR fixes/adds/changes/removes

  1. Fixes

Breaking Changes

  1. Requires a version of Bicep that supports loadJsonContent

Testing Evidence

I made this change already in the SLZ variant of ALZ and successfully deployed the environment.

As part of this Pull Request I have

@ghost
Copy link

ghost commented Oct 17, 2022

Hey KevinRabun, thanks for creating this PR.

We noticed that this PR is ammending some things related to policies (definitions or assignments) 🔍

Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.

So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo.

However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo.

Thanks from your friendly msft-bot.

@ghost ghost added Area: Policy Needs: Triage 🔍 Needs triaging by the team labels Oct 17, 2022
@jtracey93 jtracey93 self-requested a review October 17, 2022 15:19
@jtracey93 jtracey93 linked an issue Oct 17, 2022 that may be closed by this pull request
@jtracey93 jtracey93 self-assigned this Oct 20, 2022
@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Oct 20, 2022
@KevinRabun
Copy link
Contributor Author

@jtracey93 I removed the files we spoke update and updated this PR. I'll keep an eye on the linter though to make sure it is happy.

@jtracey93
Copy link
Contributor

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 5133b73 into Azure:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - Json content should be loaded using loadJsonContent
2 participants