Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Commercial Cloud - Update Policy Library - ADO #22240 #345

Merged
merged 11 commits into from
Oct 20, 2022
Merged

Azure Commercial Cloud - Update Policy Library - ADO #22240 #345

merged 11 commits into from
Oct 20, 2022

Conversation

4pplied
Copy link
Contributor

@4pplied 4pplied commented Oct 20, 2022

Overview/Summary

Addressed the failing Update Policy Library workflow to pull from new source as part of refactoring.

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Added 'Bicep' as an ExportFormat in Policy Library Update
  2. Pulls from new Policy source and put into same location in repository

Breaking Changes

  1. N/A

Testing Evidence

Policy definition:

image

Policy set:

image

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Oct 20, 2022
Copy link
Contributor

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the required changes as per other comments. Also can we remove the enterprise scale tools directory in the script folder as no longer needed.

Thanks

@@ -0,0 +1,113 @@
#!/usr/bin/pwsh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this file please

Copy link
Contributor

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@jtracey93 jtracey93 merged commit e7329ba into Azure:main Oct 20, 2022
@4pplied 4pplied deleted the policyupdates branch October 21, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants