-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter by tags #2311
Filter by tags #2311
Conversation
Is this now a dead PR, given it's six months old? Has the plan changed? What does the roadmap for adding endpoints for azure storage look like, because we still appear to be missing quite a bit. |
Hi @laurencenairne-work , I'm still work on this, will update progress recently. |
7a97c42
to
11f7add
Compare
Do you need help @EmmaZhu? We are developing something and we need this feature. |
f6ba562
to
e5a01a3
Compare
Hello @EmmaZhu I've tested the lastest changes locally and it looks really good! findBlobsByTags works perfectly! Let me know if you need anything else from me to help move this forward. |
Hi @AlexMunoz , We are trying to get this feature ready, thanks a lot for trying it and sharing your result. It'd be very helpful if you can share which scenario you have tested, and any defects seen. Thanks a lot. |
Hello @EmmaZhu Our scenario is not complex, we do this:
On request:
findBlobsByTags was the functionality we needed for local development and the implementation in your PR works for our use case. |
e5a01a3
to
e87da1e
Compare
Change the filter by blob feature from unsupported to preview |
Check SAS permission for filter blob by tags, get tags and set tags. |
445037e
to
39c7a02
Compare
da402b3
to
3ed0d3f
Compare
This is an uncompleted PR which is only to show how the basic logic works.
I'll still need to:
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
main
branch.legacy-dev
branch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Release
section inChangeLog.md
.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.