Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by tags #2311

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Filter by tags #2311

merged 3 commits into from
Oct 23, 2024

Conversation

EmmaZhu
Copy link
Member

@EmmaZhu EmmaZhu commented Nov 29, 2023

This is an uncompleted PR which is only to show how the basic logic works.
I'll still need to:

  1. Add comments on why implementation looks like this.
  2. Add support for ifTags condition for all blob operations
  3. Add documents about limitation and best practice.
  4. Add more cases for testing.
  5. Make error report more accurate.

Thanks for contribution! Please go through following checklist before sending PR.

PR Branch Destination

  • For Azurite V3, please send PR to main branch.
  • For legacy Azurite V2, please send PR to legacy-dev branch.

Always Add Test Cases

Make sure test cases are added to cover the code change.

Add Change Log

Add change log for the code change in Upcoming Release section in ChangeLog.md.

Development Guideline

Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.

@blueww blueww mentioned this pull request Dec 6, 2023
@EmmaZhu EmmaZhu changed the title Filter by tags tablequeryway Filter by tags Dec 20, 2023
@bbattezzati
Copy link

bbattezzati commented Jan 9, 2024

Hi @blueww @EmmaZhu, any update about this?
Is there anyway I could help?

@bbattezzati
Copy link

hi @blueww @EmmaZhu

I've forked [EmmaZhu:filter_by_tags_tablequeryway] branch and worked on top of it.
I worked on 2 point - support for ifTags condition for all blob operations.

Just submitted another PR.

@laurencenairne-work
Copy link

Is this now a dead PR, given it's six months old? Has the plan changed? What does the roadmap for adding endpoints for azure storage look like, because we still appear to be missing quite a bit.

@EmmaZhu
Copy link
Member Author

EmmaZhu commented May 29, 2024

Hi @laurencenairne-work , I'm still work on this, will update progress recently.

@EmmaZhu EmmaZhu force-pushed the filter_by_tags_tablequeryway branch from 7a97c42 to 11f7add Compare July 31, 2024 03:16
@AlexMunoz
Copy link

Do you need help @EmmaZhu? We are developing something and we need this feature.

@EmmaZhu EmmaZhu force-pushed the filter_by_tags_tablequeryway branch 2 times, most recently from f6ba562 to e5a01a3 Compare September 8, 2024 15:36
@AlexMunoz
Copy link

Hello @EmmaZhu I've tested the lastest changes locally and it looks really good! findBlobsByTags works perfectly! Let me know if you need anything else from me to help move this forward.

@EmmaZhu
Copy link
Member Author

EmmaZhu commented Sep 11, 2024

Hi @AlexMunoz ,

We are trying to get this feature ready, thanks a lot for trying it and sharing your result. It'd be very helpful if you can share which scenario you have tested, and any defects seen.

Thanks a lot.

@AlexMunoz
Copy link

Hello @EmmaZhu Our scenario is not complex, we do this:

  1. We create a blob and assign 3 tags to it.

On request:

  1. Using findBlobsByTags, we get all the blobs that match one of two specific tags.
  2. The resulting blob list is filtered by the values of the extra tag.
  3. At the end we download the content of the remaining blobs.

findBlobsByTags was the functionality we needed for local development and the implementation in your PR works for our use case.

@EmmaZhu EmmaZhu force-pushed the filter_by_tags_tablequeryway branch from e5a01a3 to e87da1e Compare October 8, 2024 02:23
@EmmaZhu
Copy link
Member Author

EmmaZhu commented Oct 21, 2024

Change the filter by blob feature from unsupported to preview

@EmmaZhu
Copy link
Member Author

EmmaZhu commented Oct 21, 2024

Check SAS permission for filter blob by tags, get tags and set tags.

@EmmaZhu EmmaZhu force-pushed the filter_by_tags_tablequeryway branch 3 times, most recently from 445037e to 39c7a02 Compare October 23, 2024 02:22
@EmmaZhu EmmaZhu force-pushed the filter_by_tags_tablequeryway branch from da402b3 to 3ed0d3f Compare October 23, 2024 02:49
@EmmaZhu EmmaZhu merged commit 1e7d69b into Azure:main Oct 23, 2024
34 checks passed
@EmmaZhu EmmaZhu deleted the filter_by_tags_tablequeryway branch October 23, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants