EndpointManagerTest "AddHostsFileEntry" does not work as intended

[Eneuman]

In this line it says that EndpointManagerRequest<T> where T is a IEnumerable<HostsFileEntry>.

Bridge-To-Kubernetes/src/endpointmanager.tests/EndpointManagerTests.cs

Line 41 in 7bdf738

var request = new EndpointManagerRequest<IEnumerable<HostsFileEntry>>()

Looking at the code that this test should cover:

Bridge-To-Kubernetes/src/endpointmanager/EndpointManager.cs

Line 244 in 7bdf738

var addHostsFileEntryRequest = JsonHelpers.DeserializeObject<EndpointManagerRequest<(string workloadNamespace, IEnumerable<HostsFileEntry> entries)>>(request);

T should be a tuplet of (string workloadNamespace, IEnumerable<HostsFileEntry> entries).
Yet, this test passes.

When switching to System.Text.Json this test failes.

[Eneuman]

Since System.Text.Json is not very good att handling Tuplets (alot of extra work will be needed with custom convert etc), I would suggest replacing the tuplet with a new "EndpointManagerRequestArgument" and then create separate objects for each argument type. That way you both get strongly typed objects and you can set a constraint on what can be send to the EndPointManager.

[elenavillamil]

The suggestion sounds good. We will discuss with the team on our next weekly sync and update here. Thank you very much for contributing to make bridge better!

[hsubramanianaks]

This is handled in this huge PR - #153.