-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal Network Validation Improvement #767
Conversation
@jtracey93 & @krnese Let me know whether you want me to document the changes anywhere. |
@daltondhcp - can you validate pls, for hub and spoke as well as vwan? |
@marvinbuss If you could just add a note to the Wiki "What's New?" page that would be great ( |
DONE! |
LGTM - Tested and validated in both scenarios and works exactly as intended. |
@daltondhcp & @krnese Are you ok with the Vnet and subnet range sizes? |
@marvinbuss, noticed one more thing, would it be possible to add the same validation to the corp landing zone part as well? |
Yes it is all good! |
@daltondhcp Please check my last commit. Checking real overlap is quite difficult at this point in time. Please see my analysis here: Azure/data-management-zone#148 (comment) |
Awesome, looks good and works well! |
Excellent work! |
This is great thanks guys! |
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Here are a few screenshots:
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)