Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal Network Validation Improvement #767

Merged
merged 9 commits into from
Aug 27, 2021

Conversation

marvinbuss
Copy link
Contributor

@marvinbuss marvinbuss commented Aug 26, 2021

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. This PR improves the CIDR range validation in the portal experience.

Breaking Changes

  1. No Breaking changes, just improvements of the portal validation.

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Here are a few screenshots:
image
image
image

image
image
image

As part of this Pull Request I have

@marvinbuss marvinbuss added enhancement New feature or request engineering engineering work labels Aug 26, 2021
@marvinbuss marvinbuss self-assigned this Aug 26, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner August 26, 2021 15:45
@marvinbuss marvinbuss linked an issue Aug 26, 2021 that may be closed by this pull request
@marvinbuss
Copy link
Contributor Author

@jtracey93 & @krnese Let me know whether you want me to document the changes anywhere.

@krnese
Copy link
Contributor

krnese commented Aug 27, 2021

@daltondhcp - can you validate pls, for hub and spoke as well as vwan?

@jtracey93
Copy link
Collaborator

@jtracey93 Jack Tracey FTE & @krnese Kristian Nese FTE Let me know whether you want me to document the changes anywhere.

@marvinbuss If you could just add a note to the Wiki "What's New?" page that would be great (/docs/wiki/whats-new.md) 👍

@marvinbuss marvinbuss requested a review from a team as a code owner August 27, 2021 09:31
@marvinbuss
Copy link
Contributor Author

@jtracey93 Jack Tracey FTE & @krnese Kristian Nese FTE Let me know whether you want me to document the changes anywhere.

@marvinbuss If you could just add a note to the Wiki "What's New?" page that would be great (/docs/wiki/whats-new.md) 👍

DONE!

docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
@daltondhcp
Copy link
Contributor

@daltondhcp - can you validate pls, for hub and spoke as well as vwan?

LGTM - Tested and validated in both scenarios and works exactly as intended.

@marvinbuss
Copy link
Contributor Author

@daltondhcp & @krnese Are you ok with the Vnet and subnet range sizes?

@daltondhcp
Copy link
Contributor

@marvinbuss, noticed one more thing, would it be possible to add the same validation to the corp landing zone part as well?
image

@daltondhcp
Copy link
Contributor

@daltondhcp & @krnese Are you ok with the Vnet and subnet range sizes?

Yes it is all good!

@marvinbuss
Copy link
Contributor Author

marvinbuss commented Aug 27, 2021

@marvinbuss, noticed one more thing, would it be possible to add the same validation to the corp landing zone part as well?
image

@daltondhcp Please check my last commit. Checking real overlap is quite difficult at this point in time. Please see my analysis here: Azure/data-management-zone#148 (comment)

@daltondhcp
Copy link
Contributor

@marvinbuss, noticed one more thing, would it be possible to add the same validation to the corp landing zone part as well?
image

@daltondhcp Please check my last commit.

Awesome, looks good and works well!

@daltondhcp daltondhcp merged commit 12c2d7a into Azure:main Aug 27, 2021
@krnese
Copy link
Contributor

krnese commented Aug 27, 2021

Excellent work!

@tulpy
Copy link

tulpy commented Aug 28, 2021

This is great thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering engineering work enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure firewall Subnet out of scope from Adress Space
6 participants