This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
test: configurable pvc E2E tests #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chewong FYI |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2620 +/- ##
=======================================
Coverage 71.79% 71.79%
=======================================
Files 131 131
Lines 24787 24787
=======================================
Hits 17795 17795
Misses 5966 5966
Partials 1026 1026 |
jackfrancis
force-pushed
the
e2e-pvc-test-config
branch
from
13936ff
to
1fdbf30
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR modifies the PVC E2E test implementation so that it only runs if a
TEST_PVCenv var is set totrue(in addition to other, pre-existing conditional criteria).We will ship this change w/ a change to the "everything" test cluster configuration, so that that cluster config gets PVC test coverage.
Issue Fixed:
Requirements:
Notes: