Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add new Standard_DC[x]s_v2 VM SKUs #2647

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Conversation

mboersma
Copy link
Member

Reason for Change:
Adds four new VM SKUs picked up by the pkg/helpers/generate_azure_constants.py script:

  • Standard_DC1s_v2
  • Standard_DC2s_v2
  • Standard_DC4s_v2
  • Standard_DC8_v2

Issue Fixed:

Requirements:

Notes:
According to the accelerated networking query these VM types do not support accelerated networking, so they weren't added to that list.

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #2647 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2647      +/-   ##
==========================================
+ Coverage   71.76%   71.77%   +0.01%     
==========================================
  Files         134      134              
  Lines       25001    25017      +16     
==========================================
+ Hits        17941    17957      +16     
  Misses       6010     6010              
  Partials     1050     1050

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jan 29, 2020
@acs-bot acs-bot merged commit 8cb0934 into Azure:master Jan 29, 2020
@mboersma mboersma deleted the new-skus branch January 29, 2020 21:37
@acs-bot
Copy link

acs-bot commented Jan 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis added this to the v0.47.0 milestone Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants