Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: update CSE moby version substring match #2662

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Follow-up from #2613. Now that we are delivering a +azure suffix w/ the internal Azure builds moby, we need to strip that from the version substring fetcher in CSE.

Issue Fixed:

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

@cpuguy83 FYI, should have caught this in the PR review

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #2662 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2662   +/-   ##
=======================================
  Coverage   71.75%   71.75%           
=======================================
  Files         134      134           
  Lines       25056    25056           
=======================================
  Hits        17978    17978           
  Misses       6023     6023           
  Partials     1055     1055

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 84909ed into Azure:master Feb 1, 2020
@jackfrancis jackfrancis deleted the moby-install-version-substring branch February 1, 2020 01:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants