Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: don't refer to hyperkube in template if > 1.16 #2676

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR doesn't add an unused KUBELET_IMAGE env var in the /etc/default/kubelet config file if the Kubernetes version is >= 1.17.0, because we don't support hyperkube starting with that version of k8s.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #2676 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2676   +/-   ##
=======================================
  Coverage   71.77%   71.77%           
=======================================
  Files         134      134           
  Lines       25071    25071           
=======================================
  Hits        17995    17995           
  Misses       6021     6021           
  Partials     1055     1055

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit c0b34d9 into Azure:master Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants