This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: deprecate kata-containers #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3014 +/- ##
==========================================
- Coverage 72.11% 72.11% -0.01%
==========================================
Files 142 142
Lines 26273 26270 -3
==========================================
- Hits 18948 18945 -3
Misses 6230 6230
Partials 1095 1095 |
mboersma
added
the
needs-rebase
jackfrancis
force-pushed
the
deprecate-kata-containers
branch
from
35f49be
to
b751e6e
Compare
mboersma
removed
the
needs-rebase
mboersma
approved these changes
Apr 3, 2020
| @@ -1648,6 +1648,11 @@ func (a *Properties) validateContainerRuntime() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Check for deprecated, non-back-compat | |||
| if isUpdate && containerRuntime == KataContainers { | |||
| return errors.Errorf("%s containerRuntime has been deprecated, you will not be able to update this cluster with this version of aks-engine", KataContainers) | |||
| @@ -362,13 +362,11 @@ | |||
| "containerRuntime": { | |||
| "allowedValues": [ | |||
| "docker", | |||
| "clear-containers", | |||
There was a problem hiding this comment.
A twofer with clear-containers, nice to clean out the cruft.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR officially deprecates "kata-containers" container runtime support in AKS Engine. This experimental feature has become stale, and it no longer works. The most user-friendly action at this point is to remove its support entirely, so as not to confuse folks who may stumble onto this and spend a lot of time getting something to work that probably doesn't.
Issue Fixed:
Fixes #2618
Requirements:
Notes: