Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: upgrade to azure-sdk v41.0.0 #3035

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Conversation

andyzhangx
Copy link
Contributor

@andyzhangx andyzhangx commented Apr 7, 2020

Reason for Change:

This PR upgrade azure-sdk to support features, e.g. BYOK encryption on host

vi go.mod

grep "2019-07-01/compute" ./* -R

sed -i 's/2019-07-01\/compute/2019-12-01\/compute/g' ./pkg/armhelpers/*.go
sed -i 's/2019-07-01\/compute/2019-12-01\/compute/g' ./pkg/engine/*.go
sed -i 's/2019-07-01\/compute/2019-12-01\/compute/g' ./pkg/operations/kubernetesupgrade/*.go
sed -i 's/2019-07-01\/compute/2019-12-01\/compute/g' ./pkg/armhelpers/azurestack/*.go
sed -i 's/2019-07-01\/compute/2019-12-01\/compute/g' ./pkg/armhelpers/utils/*.go
sed -i 's/2019-07-01\/compute/2019-12-01\/compute/g' ./pkg/engine/transform/transform.go
sed -i 's/2019-07-01\/compute/2019-12-01\/compute/g' ./cmd/rotate_certs_test.go

go mod vendor
go mod tidy

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #3035 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3035   +/-   ##
=======================================
  Coverage   70.58%   70.58%           
=======================================
  Files         145      145           
  Lines       25105    25105           
=======================================
  Hits        17721    17721           
  Misses       6281     6281           
  Partials     1103     1103           
Impacted Files Coverage Δ
pkg/armhelpers/azureclient.go 35.95% <ø> (ø)
pkg/armhelpers/azurestack/compute.go 36.03% <ø> (ø)
pkg/armhelpers/azurestack/resultPageClient.go 33.33% <ø> (ø)
pkg/armhelpers/azurestack/vmImage.go 76.47% <ø> (ø)
pkg/armhelpers/compute.go 32.91% <ø> (ø)
pkg/armhelpers/httpMockClient.go 58.46% <ø> (ø)
pkg/armhelpers/mockclients.go 22.52% <ø> (ø)
pkg/armhelpers/utils/util.go 70.88% <ø> (ø)
pkg/armhelpers/vmImage.go 100.00% <ø> (ø)
pkg/engine/armresources.go 78.18% <ø> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e1a16...fa80986. Read the comment docs.

@andyzhangx
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mboersma
mboersma previously approved these changes Apr 7, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @devigned do you know of any reasons we wouldn't want to jump up to azure-sdk-for-go v40.2.0?

@CecileRobertMichon
Copy link
Contributor

why not move to 0.41.0?

@zqingqing1
Copy link
Member

@andyzhangx is that good to bump it a little higher to 41.0.0?

@andyzhangx
Copy link
Contributor Author

/hold
let me bump to 41.0.0

@andyzhangx andyzhangx changed the title chore: upgrade to azure-sdk v40.2.0 chore: upgrade to azure-sdk v41.0.0 Apr 8, 2020
fix: build test failure

fix test failure
@andyzhangx
Copy link
Contributor Author

/hold cancel
already bumped to v41.0.0

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mboersma mboersma merged commit 58059b4 into Azure:master Apr 8, 2020
@andyzhangx
Copy link
Contributor Author

@zqingqing1 this PR is merged in master branch, are you going to make it into aks-release-v0.47.0-1 branch?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants