Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: remove unnecessary apt lock waits #3049

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR removes superfluous "wait for no held apt locks" after apt operations have already completed. Instead we are waiting only before attempting an apt operation. This configuration in concert will promote good apt race condition avoidance without unnecessarily blocking CSE progression (for example, the next operation after an apt operation is probably not another apt operation, and so waiting for apt locks to be released means we're delaying that next operation unnecessarily).

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #3049 into master will increase coverage by 0.04%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
+ Coverage   70.58%   70.62%   +0.04%     
==========================================
  Files         145      145              
  Lines       25105    25147      +42     
==========================================
+ Hits        17721    17761      +40     
- Misses       6281     6283       +2     
  Partials     1103     1103              
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 31.57% <ø> (ø)
pkg/helpers/helpers.go 79.83% <88.23%> (+1.40%) ⬆️
pkg/api/vlabs/validate.go 79.03% <100.00%> (+0.40%) ⬆️
pkg/api/types.go 94.05% <0.00%> (ø)
pkg/api/vlabs/types.go 74.31% <0.00%> (ø)
pkg/api/convertertoapi.go 93.63% <0.00%> (+0.02%) ⬆️
pkg/api/converterfromapi.go 93.82% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a34150...39e3a1f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #3049 into master will increase coverage by 0.04%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
+ Coverage   70.58%   70.62%   +0.04%     
==========================================
  Files         145      145              
  Lines       25105    25147      +42     
==========================================
+ Hits        17721    17761      +40     
- Misses       6281     6283       +2     
  Partials     1103     1103              
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 31.57% <ø> (ø)
pkg/helpers/helpers.go 79.83% <88.23%> (+1.40%) ⬆️
pkg/api/vlabs/validate.go 79.03% <100.00%> (+0.40%) ⬆️
pkg/api/types.go 94.05% <0.00%> (ø)
pkg/api/vlabs/types.go 74.31% <0.00%> (ø)
pkg/api/convertertoapi.go 93.63% <0.00%> (+0.02%) ⬆️
pkg/api/converterfromapi.go 93.82% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a34150...39e3a1f. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Rationale makes sense to me as well. Simpler is better too.

@mboersma mboersma merged commit b19c9e7 into Azure:master Apr 9, 2020
@jackfrancis jackfrancis deleted the apt_get_purge-wait branch April 9, 2020 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants