Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: E2E scale scenario broken if update is false #3852

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Sep 21, 2020

Reason for Change:

This PR fixes a scoping bug in the cluster.sh script used to simulate E2E operations.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #3852 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3852   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23171    23171           
=======================================
  Hits        16876    16876           
  Misses       5178     5178           
  Partials     1117     1117           
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <0.00%> (ø)
pkg/engine/templates_generated.go 48.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdaf27e...e926a95. Read the comment docs.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acs-bot
Copy link

acs-bot commented Sep 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit e9cfa6a into Azure:master Sep 22, 2020
@jackfrancis jackfrancis deleted the e2e-cluster-sh-scope-errata branch September 22, 2020 00:26
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants