Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: E2E optionally validates rotate-certs #3866

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

jadarsie
Copy link
Member

Reason for Change:

Run aks-engine rotate-certs before make test-kubernetes if ROTATE_CERTS flag is set

ROTATE_CERTS should default to false as rotate-certs has regressed.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #3866 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3866   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23171    23171           
=======================================
  Hits        16876    16876           
  Misses       5178     5178           
  Partials     1117     1117           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 48.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a577d...7cae239. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Sep 25, 2020
@jackfrancis jackfrancis merged commit 1f3c4da into Azure:master Sep 25, 2020
@acs-bot
Copy link

acs-bot commented Sep 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jadarsie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants