Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: not nil defense broke logic #3881

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Sep 30, 2020

Reason for Change:

This PR fixes a logical bug introduced in #3857. Many of our test configs don't declare a kubernetesConfig object in the input API model, which means environment variable-derivd service principal injection will be skipped. That's not what we want!

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Sep 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #3881 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3881   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23203    23203           
=======================================
  Hits        16900    16900           
  Misses       5182     5182           
  Partials     1121     1121           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd327a...30fa6d7. Read the comment docs.

@jackfrancis jackfrancis merged commit 908214e into Azure:master Sep 30, 2020
@jackfrancis jackfrancis deleted the e2e-not-nil-defense-fix branch September 30, 2020 19:51
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants