Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: don't warn about CRI update on cluster create #3890

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR changes the CRI update warning in docker config scenarios so that it only logs on scale or upgrade, matching the log implementation of the containerd flow.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Oct 2, 2020
@acs-bot
Copy link

acs-bot commented Oct 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@409280e). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3890   +/-   ##
=========================================
  Coverage          ?   72.83%           
=========================================
  Files             ?      149           
  Lines             ?    23204           
  Branches          ?        0           
=========================================
  Hits              ?    16901           
  Misses            ?     5182           
  Partials          ?     1121           
Impacted Files Coverage Δ
pkg/api/defaults.go 92.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409280e...246517a. Read the comment docs.

@jackfrancis jackfrancis merged commit 1854c48 into Azure:master Oct 6, 2020
@jackfrancis jackfrancis deleted the unnecessary-containerd-warning branch October 6, 2020 22:24
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants