Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: fix jumpbox custom data #3896

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

CecileRobertMichon
Copy link
Contributor

Reason for Change:

This fixes two issues with custom data run command:

  1. retrycmd_if_failure no longer exists, replaced with retrycmd
  2. executing the cse helpers script as a shell script causes errors like /var/lib/cloud/instance/scripts/runcmd: 11: /opt/azure/containers/provision_source.sh: [[: not found in cloud init logs because [[ is a bash builtin. Use source instead.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot acs-bot added the size/S label Oct 6, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis
Copy link
Member

thx @CecileRobertMichon!

@acs-bot
Copy link

acs-bot commented Oct 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit b50086e into Azure:master Oct 7, 2020
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants