Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

ImportError are passed when it's not caused by manual files not exist #762

Closed
fengzhou-msft opened this issue Feb 26, 2021 · 1 comment
Closed

Comments

@fengzhou-msft
Copy link
Member

Machine Learning Team is working on a new extension and they did a lot of manual code to use their own SDK. They have some import errors when using their own SDKs, but the current code in custom.py below will just ignore any ImportError and CLI will eventually throw an error like ModuleNotFoundError: No module named 'azure.ml'. This cost them a lot of effort finding the real issue.

It may be a good idea to only pass ImportError for the .manual.custom part.

from .generated.custom import *  # noqa: F403
try:
    from .manual.custom import *  # noqa: F403
except ImportError:
    pass
@qiaozha
Copy link
Member

qiaozha commented Mar 25, 2021

close it as supported in master branch. Please use latest private release to make it work.

@qiaozha qiaozha closed this as completed Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants