Manual config feature gap after refactor #827
Conversation
src/generate/codemodel/Command.ts
Outdated
| @@ -25,8 +25,8 @@ export interface CommandModel { | |||
| Command_Mode: string; | |||
| Command_Type: string; | |||
| Command_GenericSetterArgName: string; | |||
| // Command_Features: [string, string]; | |||
| // Command_Imports: [string, string[]]; | |||
| Command_Features: Record<string, any>; | |||
There was a problem hiding this comment.
the value type of Features is a string? wondering is it necessary to use 'any'?
There was a problem hiding this comment.
Not exactly. I don't want to rule out the possiblity of other complex cases. For example
directive:
command: some-command-name
feature:
some_feature:
- a
- 'b'
some_feature1:
a1: a2
'b1': 'b2'
There was a problem hiding this comment.
I see. Will it be related to below code? looks currently only string type is handled for "feature"
There was a problem hiding this comment.
Actually this works for both string or number type, I need to add logic about the complex scenario I mentioned above
There was a problem hiding this comment.
yes, if it's also supposed to by a number, it will be better to use "prop: string|number"
| features: | ||
| exception_handler: handle_template_based_exception | ||
| imports: | ||
| azure.cli.core.exception: handle_template_based_exception |
There was a problem hiding this comment.
As other pairs are using name-value format, and this seems to be a different pattern, need to verify whether it would cause confusion.
There was a problem hiding this comment.
will discuss with CLI team about it
| } | ||
| importValues.forEach((val) => { | ||
| if (list.indexOf(val) === -1) { | ||
| list.push(val); |
There was a problem hiding this comment.
Does CLI have the requirement to order all the import values?
* command-interfaces-user-cases-document * document update * group change * bugfixes and doc improvement * update group description * remove new sdk release impact on scenario test * autorest directive and cli directive document * refactor of code model impl * fix codemoel layer * refactor fixes * refactor * reserve work * refactor the codemodel * example refactor * resolve conflict part * resolve conflicts * Manual config feature gap after refactor (#827) * manual-config-feature-gap-after-refactor * fix-test * add test config * manual config features and tests * scenario test * add array type example * feature type * remove unused reference
No description provided.