Add a doc comment for PollUntilDone() freq arg #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
approved these changes
Oct 26, 2021
src/generator/responses.ts
Outdated
| @@ -91,7 +91,7 @@ function generateUnmarshallerForResultEnvelope(structDef: StructDef) { | |||
| structDef.Methods.push({ name: 'UnmarshalJSON', desc: `UnmarshalJSON implements the json.Unmarshaller interface for type ${structDef.Language.name}.`, text: unmarshaller }); | |||
| } | |||
|
|
|||
| function generatePollUntilDoneForResponse(structDef: StructDef) { | |||
| function generatePollUntilDoneForResponse(structDef: StructDef, isAzure: boolean) { | |||
There was a problem hiding this comment.
I may be missing some context. Naively, this seems more to the point:
Suggested change
| function generatePollUntilDoneForResponse(structDef: StructDef, isAzure: boolean) { | |
| function generatePollUntilDoneForResponse(structDef: StructDef, isARM: boolean) { |
There was a problem hiding this comment.
So there are three pivots on the type, data-plane, arm and azure-arm. arm is the default if you don't specify anything, which is different from azure-arm which is specified in the config file and lights up additional Azure ARM-specific things. This param is to indicate the azure-arm bucket, I did rename it a bit though for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.