Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Base64Url format #1129

Closed
tbombach opened this issue Jun 3, 2016 · 4 comments
Closed

Support Base64Url format #1129

tbombach opened this issue Jun 3, 2016 · 4 comments
Assignees
Labels
Go P2 - Requested Feature Request

Comments

@tbombach
Copy link
Member

tbombach commented Jun 3, 2016

AutoRest modeler supports a base64url format for string types. This is implemented in some languages, but requires serialization/deserialization code in some remaining languages.

This issue: #805 tracked the changes needed in the modeler. It was implemented in C# in this PR: #878

Here is the specification for Base64Url format: https://tools.ietf.org/html/rfc4648#page-7

@tbombach
Copy link
Member Author

tbombach commented Jun 3, 2016

@jianghaolu I've assigned this to you for the Java implementation, but please re-assign to someone else if they're going to end up doing this work.

@jianghaolu
Copy link
Contributor

Thanks @tbombach

@pomortaz
Copy link

@jianghaolu there are issues with the solution when generating the code.

Error with :

    public byte[] result() {
        if (this.result == null) {
            return null;
        }
        return this.result.getbyte[]();
    } 

Error for not accepting byte[] in the constructor of Base64Url:

    public KeyOperationsParameters withValue(byte[] value) {
        this.value = new Base64Url(value);
        return this;
    } 

@vishrutshah vishrutshah added this to the Backlog milestone Nov 9, 2016
@vishrutshah vishrutshah added the P2 - Requested Feature Request label Nov 9, 2016
@fearthecowboy fearthecowboy removed this from the Backlog milestone Jun 22, 2017
@olydis olydis assigned marstr and mcardosos and unassigned jianghaolu Jul 18, 2017
@marstr marstr assigned jhendrixMSFT and unassigned marstr and mcardosos Nov 12, 2018
@jhendrixMSFT
Copy link
Member

This is tracked in Azure/azure-sdk-for-go#2111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go P2 - Requested Feature Request
Projects
None yet
Development

No branches or pull requests

8 participants