Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider erroring loudly on node < 14 #4090

Closed
chamons opened this issue Apr 20, 2021 · 4 comments · Fixed by #4092
Closed

Consider erroring loudly on node < 14 #4090

chamons opened this issue Apr 20, 2021 · 4 comments · Fixed by #4092

Comments

@chamons
Copy link

chamons commented Apr 20, 2021

We've had a number of internal uses crash or have incorrect behavior with node 10 installed.

Could we bump the node check to yell if < 14?
@chamons
Copy link
Author

chamons commented Apr 20, 2021

cc @timotheeguerin

@timotheeguerin
Copy link
Member

Node 10+ is meant to be supported, what errors have you seen?

@timotheeguerin timotheeguerin mentioned this issue Apr 20, 2021
Closed
@timotheeguerin
Copy link
Member

timotheeguerin commented Apr 20, 2021 •
edited
Loading

Seems to be saving the files in the wrong location for some reason(~/.autorest folder)
image

@timotheeguerin
Copy link
Member

timotheeguerin commented Apr 20, 2021 •
edited
Loading

Ok so actually this was a bug in an older version of node 10 nodejs/node#25265, which returned non windows path and caused comparaison to fail. using the latest node 10 resolve it. Have to figure out which version this was solved.

@timotheeguerin timotheeguerin mentioned this issue Apr 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump minimum node version from 10.12 -> 10.16 Azure/autorest
2 participants
@timotheeguerin @chamons