Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to @autorest/python 5.x for vmware #2630

Closed
ctaggart opened this issue Nov 5, 2020 · 1 comment · Fixed by #2920
Closed

update to @autorest/python 5.x for vmware #2630

ctaggart opened this issue Nov 5, 2020 · 1 comment · Fixed by #2920
Assignees
@ctaggart
Labels
extension/vm-repair Service Attention This issue is responsible by Azure service team.

Comments

@ctaggart
Copy link
Contributor

ctaggart commented Nov 5, 2020

Extension name (the extension in question)

vmware

Description of issue (in as much detail as possible)

The autorest python version needs to be updated. It is currently using 3.0.62, but it has a problem creating empty json Azure/autorest.python#653. Newer versions like 5.4.0 do not have that problem. A workaround was put in place to Swagger API spec, but that workaround causes problems with Swagger KPI correctness. The workaround Swagger API spec will be removed next week in the 2020-03-20 API when Azure/azure-rest-api-specs#11486 is merged.

To be clear, the existing generated code that is committed will continue to work. Using autorest.python 3.x with the updated spec and new AVS specs will not work due to Azure/autorest.python#653 bug.
@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Nov 5, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 5, 2020

@jsntcy for awareness.

@yungezz yungezz added extension/vm-repair Service Attention This issue is responsible by Azure service team. labels Nov 6, 2020
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Nov 6, 2020
@ctaggart ctaggart mentioned this issue Jan 20, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctaggart ctaggart

Labels
extension/vm-repair Service Attention This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade vmware extension to use AutoRest Python 5.6.0 ctaggart/azure-cli-extensions
3 participants
@ctaggart @yungezz @yonzhan