From 4cb40e61f886dcaa43b5be144c6d3e3cd6658d68 Mon Sep 17 00:00:00 2001 From: Saurabh Sarkar Date: Fri, 22 Jun 2018 15:09:18 -0700 Subject: [PATCH 1/2] Updating output messages to be printed in default mode --- src/dev-spaces-preview/azext_dev_spaces_preview/custom.py | 6 +++++- src/dev-spaces-preview/setup.py | 2 +- src/index.json | 8 ++++---- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/dev-spaces-preview/azext_dev_spaces_preview/custom.py b/src/dev-spaces-preview/azext_dev_spaces_preview/custom.py index c84a6d4c622..bae93ebfa42 100644 --- a/src/dev-spaces-preview/azext_dev_spaces_preview/custom.py +++ b/src/dev-spaces-preview/azext_dev_spaces_preview/custom.py @@ -119,7 +119,11 @@ def _install_dev_spaces_cli(force_install): if should_install_azds: # Install AZDS - logger.info('Installing Dev Spaces (Preview) commands...') + print('Installing Dev Spaces (Preview) commands...') + if system == 'Windows': + print('A separate window will open to guide you through the installation process.') + else: + print('The following dependencies will be installed: curl, unzip, dotnet.') urlretrieve(setup_url, setup_file) try: subprocess.call( diff --git a/src/dev-spaces-preview/setup.py b/src/dev-spaces-preview/setup.py index 44b5d14fe45..ca2b48cea6d 100644 --- a/src/dev-spaces-preview/setup.py +++ b/src/dev-spaces-preview/setup.py @@ -7,7 +7,7 @@ from setuptools import setup, find_packages -VERSION = "0.1.5" +VERSION = "0.1.6" CLASSIFIERS = [ 'Development Status :: 4 - Beta', diff --git a/src/index.json b/src/index.json index 2ba14c5de99..cd9b458ee36 100644 --- a/src/index.json +++ b/src/index.json @@ -370,9 +370,9 @@ ], "dev-spaces-preview": [ { - "filename": "dev_spaces_preview-0.1.5-py2.py3-none-any.whl", - "sha256Digest": "28077ae576f5a86dca30f7def0308d3a26d7464f91f82109c1dc8fc4b11c6a6f", - "downloadUrl": "https://azuredevspacestools.blob.core.windows.net/azdssetup/LKS/dev_spaces_preview-0.1.5-py2.py3-none-any.whl", + "filename": "dev_spaces_preview-0.1.6-py2.py3-none-any.whl", + "sha256Digest": "254a7168b0783427e7dbceb71d0e0a9037b8056114e346f22a9a33bdb0d44f46", + "downloadUrl": "https://azuredevspacestools.blob.core.windows.net/azdssetup/LKS/dev_spaces_preview-0.1.6-py2.py3-none-any.whl", "metadata": { "azext.isPreview": true, "azext.minCliCoreVersion": "2.0.32", @@ -411,7 +411,7 @@ "metadata_version": "2.0", "name": "dev-spaces-preview", "summary": "Dev Spaces provides a rapid, iterative Kubernetes development experience for teams.", - "version": "0.1.5" + "version": "0.1.6" } } ], From bb6a4a47dc7e2bddb5dc08b7cf50f8df828ba0cf Mon Sep 17 00:00:00 2001 From: Saurabh Sarkar Date: Fri, 22 Jun 2018 16:35:53 -0700 Subject: [PATCH 2/2] Code Review Update --- src/dev-spaces-preview/azext_dev_spaces_preview/custom.py | 7 +++---- src/index.json | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/dev-spaces-preview/azext_dev_spaces_preview/custom.py b/src/dev-spaces-preview/azext_dev_spaces_preview/custom.py index bae93ebfa42..ccffd63adce 100644 --- a/src/dev-spaces-preview/azext_dev_spaces_preview/custom.py +++ b/src/dev-spaces-preview/azext_dev_spaces_preview/custom.py @@ -119,11 +119,10 @@ def _install_dev_spaces_cli(force_install): if should_install_azds: # Install AZDS - print('Installing Dev Spaces (Preview) commands...') + logger.warning('Installing Dev Spaces (Preview) commands...') if system == 'Windows': - print('A separate window will open to guide you through the installation process.') - else: - print('The following dependencies will be installed: curl, unzip, dotnet.') + logger.warning('A separate window will open to guide you through the installation process.') + urlretrieve(setup_url, setup_file) try: subprocess.call( diff --git a/src/index.json b/src/index.json index cd9b458ee36..bc9189cc6c3 100644 --- a/src/index.json +++ b/src/index.json @@ -371,7 +371,7 @@ "dev-spaces-preview": [ { "filename": "dev_spaces_preview-0.1.6-py2.py3-none-any.whl", - "sha256Digest": "254a7168b0783427e7dbceb71d0e0a9037b8056114e346f22a9a33bdb0d44f46", + "sha256Digest": "cd0fc8a0f684b561e53c1deb235b3cfa85ef7a4df5f52d67cec6dcba5a9494ae", "downloadUrl": "https://azuredevspacestools.blob.core.windows.net/azdssetup/LKS/dev_spaces_preview-0.1.6-py2.py3-none-any.whl", "metadata": { "azext.isPreview": true,