Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiskRP 2020-06-30 CLI changes #14899

Closed
laurawu19 opened this issue Aug 25, 2020 · 8 comments · Fixed by #15031
Closed

DiskRP 2020-06-30 CLI changes #14899

laurawu19 opened this issue Aug 25, 2020 · 8 comments · Fixed by #15031
Assignees
Labels
Compute az vm/vmss/image/disk/snapshot Service Team Support Request

Comments

@laurawu19
Copy link

Resource Provider
Microsoft.Azure.Management.Compute (specifically DiskRP)

Description of Feature or Work Requested
Customers can create ultra disks with specific logicalSectorSize. The support values are 4096 and 512. And 4096 is the default value.

Customers can set performance tier of the disks when creating premium disks.

Customers can list associated resources which are using a specific disk encryption set.

We also exposed some fields for shared disks to customers and allow customers to update those properties.

Powershell Design doc: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/725

Minimum API Version Required
2020-06-30

Swagger Link
Azure/azure-rest-api-specs#10208

Target Date
Next CLI release

@ghost ghost added needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 25, 2020
@Juliehzl Juliehzl added the Compute az vm/vmss/image/disk/snapshot label Aug 25, 2020
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Aug 25, 2020
@Azure Azure deleted a comment from yonzhan Aug 25, 2020
@yungezz yungezz added Feature Request Service Team Support Request and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 25, 2020
@yungezz
Copy link
Member

yungezz commented Aug 25, 2020

hi @laurawu19 will sync with you on timeline via email.

@qwordy
Copy link
Member

qwordy commented Aug 26, 2020

4k alignment? What's the benefit of 512?

@laurawu19
Copy link
Author

4k alignment? What's the benefit of 512?

Hi @qwordy ,
Ultra disk is a 4k native disk. There are some customers, for example, Blackrock using legacy apps or applications that allow < 4K IOs sector size (512E). So, diskRP introduces this property to support customers to create disks with 512E logicalSectorSize.

@qwordy
Copy link
Member

qwordy commented Sep 3, 2020

512 doesn't work for me. 4096 works.

Deployment failed. Correlation ID: b398e722-ad7a-4544-93c7-f5e43a332fac. Exception creating storage object https://md-dd-a98de607f8a0431b9d47deb1b486fc3a.disk.core.windows.net/disks/a98de607-f8a0-431b-9d47-deb1b486fc3a

@qwordy
Copy link
Member

qwordy commented Sep 4, 2020

Hi Lu. Some questions
1.What is tier? What's the corresponding swagger definition?
I find a "tier". It is read only.

class DiskSku(Model):
    """The disks sku name. Can be Standard_LRS, Premium_LRS, StandardSSD_LRS, or
    UltraSSD_LRS.

    Variables are only populated by the server, and will be ignored when
    sending a request.

    :param name: The sku name. Possible values include: 'Standard_LRS',
     'Premium_LRS', 'StandardSSD_LRS', 'UltraSSD_LRS'
    :type name: str or
     ~azure.mgmt.compute.v2020_06_30.models.DiskStorageAccountTypes
    :ivar tier: The sku tier.
    :vartype tier: str
    """

    _validation = {
        'tier': {'readonly': True},
    }

2.List associated resources which are using a specific disk encryption set
Is there a REST API for it? How do you implement it in PowerShell?

Thanks,

@laurawu19
Copy link
Author

Hi Feiyue,

  1. The "tier" refers to performance tier of the disk (e.g, P4, S10) and is different from the DiskTier in DiskSku model.
    Here is the description: https://azure.microsoft.com/en-us/pricing/details/managed-disks/

  2. Yes. There is an API for it.
    Powershell command:
    Get-DiskManagerDiskEncryptionSetAssociatedResources -SubscriptionId sub -ResourceGroup rg --DiskEncryptionSetName desName -Region region

RestAPI:
Get
subscriptions/{subId}/resourceGroups/{rg}/providers/Microsoft.Compute/{diskEncryptionSets}/{name}/associatedResources

@qwordy
Copy link
Member

qwordy commented Sep 4, 2020

Thanks Lu

@rahul602
Copy link

rahul602 commented Sep 9, 2020

@qwordy ,

It's probably clear to you from Lu's comment, but I would still like to mention this for your reference. The sku tier is difference from the performance tier.
This is the swagger for it:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-30/disk.json

    "tier": {
      "type": "string",
      "description": "Performance tier of the disk (e.g, P4, S10) as described here: https://azure.microsoft.com/en-us/pricing/details/managed-disks/. Does not apply to Ultra disks."
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute az vm/vmss/image/disk/snapshot Service Team Support Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants