Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Network] Support new ciphers and SciState Express Route link #18707

Closed
Niteesh opened this issue Jul 1, 2021 · 3 comments · Fixed by #18814
Closed

[Network] Support new ciphers and SciState Express Route link #18707

Niteesh opened this issue Jul 1, 2021 · 3 comments · Fixed by #18814
Assignees
@kairu-ms
Labels
feature-request Network az network vnet/lb/nic/dns/etc...
Milestone
Jul 2021 (2021-08...

Comments

@Niteesh
Copy link

Niteesh commented Jul 1, 2021

Is your feature request related to a problem? Please describe.

Support for new ciphers ( "GcmAesXpn128", "GcmAesXpn256") and SciState for ExpressRouteLink (ExpressRoute Direct)

The powershell support has been added in Azure/azure-powershell#13928

swagger definition is here.
https://github.com/Azure/azure-rest-api-specs/blob/8a09ea0b84aa36cb0e56bab4f4c8efd83a6fdcf6/specification/network/resource-manager/Microsoft.Network/stable/2020-08-01/expressRoutePort.json#L696

Describe the solution you'd like

Similar to the powershell, az-cli should also allow these 2 ciphers and SciState to be toggled for ExpressRouteLink in ExpressRouteLinkMacSecConfig.

Describe alternatives you've considered

Additional context
@ghost ghost added needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 1, 2021
@yonzhan yonzhan added the Network az network vnet/lb/nic/dns/etc... label Jul 1, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jul 1, 2021
@yonzhan yonzhan removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Jul 1, 2021
@yonzhan yonzhan added this to the Jul 2021 (2021-08-03) milestone Jul 1, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 1, 2021

network

@kairu-ms kairu-ms mentioned this issue Jul 12, 2021
Merged
3 tasks
@Niteesh
Copy link
Author

Niteesh commented Jul 12, 2021

In the above PR I do not see changes for new ciphers ( "GcmAesXpn128", "GcmAesXpn256"), will these be automatically picked up from the swagger?

@kairu-ms
Copy link
Contributor

kairu-ms commented Jul 12, 2021 •
edited
Loading

In the above PR I do not see changes for new ciphers ( "GcmAesXpn128", "GcmAesXpn256"), will these be automatically picked up from the swagger?

Yes. They are automatically picked from the enum value in python SDK.

@jsntcy jsntcy closed this as completed Jul 26, 2021
@jsntcy jsntcy reopened this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kairu-ms kairu-ms

Labels
feature-request Network az network vnet/lb/nic/dns/etc...
Projects
None yet
Milestone
Jul 2021 (2021-08-03)
4 participants
@Niteesh @jsntcy @yonzhan @kairu-ms