Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNS] DNS record management commands should support --if-match #2092

Closed
jtuliani opened this issue Feb 15, 2017 · 4 comments · Fixed by #11900
Closed

[DNS] DNS record management commands should support --if-match #2092

jtuliani opened this issue Feb 15, 2017 · 4 comments · Fixed by #11900
Assignees
Labels
Network az network vnet/lb/nic/dns/etc...
Milestone

Comments

@jtuliani
Copy link

The commands under 'az network dns record ...' are used to add/remove records from DNS record sets. They can also create a new record set if one does not already exist.

These operations need to support optimistic concurrency to protect against concurrent changes.

To address this, the '--if-match ' parameter should be supported on both the 'add' and 'remove' commands (and 'update-soa').

When the record set doesn't already exist and thus a new record set is being created, the command should always include '--if-none-match *' to protect against concurrent operations. This this should always be applied in this case, there is no need to expose it in the command parameters.

@tjprescott tjprescott added the Network az network vnet/lb/nic/dns/etc... label Feb 15, 2017
@tjprescott tjprescott added this to the Backlog milestone Feb 15, 2017
@jtuliani jtuliani changed the title [DNS] DNS record management commands should support if-match and if-none-match [DNS] DNS record management commands should support --if-match Feb 16, 2017
@tjprescott tjprescott modified the milestones: Sprint 14, Backlog Mar 13, 2017
@tjprescott tjprescott self-assigned this Mar 13, 2017
@tjprescott tjprescott modified the milestones: Sprint 15, Sprint 14 Mar 15, 2017
@tjprescott tjprescott modified the milestones: Backlog, Sprint 15 Apr 4, 2017
@tjprescott tjprescott added Network - DNS az network dns and removed Network az network vnet/lb/nic/dns/etc... labels Nov 29, 2018
@tjprescott tjprescott removed this from the Backlog milestone Nov 29, 2018
@tjprescott tjprescott removed their assignment Jul 29, 2019
@mmyyrroonn mmyyrroonn added Needs Triage Network az network vnet/lb/nic/dns/etc... labels Jul 31, 2019
@yonzhan yonzhan removed the triage label Sep 2, 2019
@yonzhan yonzhan added the Network az network vnet/lb/nic/dns/etc... label Nov 1, 2019
@yonzhan yonzhan added this to the S162 milestone Nov 1, 2019
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 1, 2019

@myronfanqiu add to S162.

@mmyyrroonn
Copy link
Contributor

@jtuliani Hello. The suggestion sounds good. But I don't want to bring breaking change to user suddenly. I add warning information in #11900 and create a new issue #11901 to do it.

@jtuliani
Copy link
Author

Thank you!

@mmyyrroonn
Copy link
Contributor

@jtuliani Hello. Thanks for feedback. Do you still remember your original thoughts? I want to double confirm, do you want an extra argument '--if-not-match. Only the command with --if-not-match will create a new record-set for customer by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Network az network vnet/lb/nic/dns/etc...
Projects
None yet
4 participants