Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making 2023-09-01 api-version as default for VMSS operations #28080

Closed
1 task done
mannanbansal opened this issue Dec 21, 2023 · 4 comments · Fixed by #28122
Closed
1 task done

Making 2023-09-01 api-version as default for VMSS operations #28080

mannanbansal opened this issue Dec 21, 2023 · 4 comments · Fixed by #28122
Assignees
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot feature-request

Comments

@mannanbansal
Copy link

Preconditions

  • No need to upgrade Python SDK or the Python SDK is ready.

Related command

az vmss create
az vmss update

Resource Provider

Microsoft.Compute

Description of Feature or Work Requested

Some of the new feature offerings for VMSS flex has been rolled out under 2023-09-01 api-version. Although customer is able to use those features through SDK, PS etc. but we need to update CLI also for these features. One of those features is instanceProtection which is already there for VMSS Uniform and works fine with CLI, and I see there are no client-side validation for this feature while executing command for VMSS flex. And there are some key customers who use CLI for these operations. We just need to update api-version for VMSS in CLI, as there are no client side validations while running the command.
Command:
For Eg: az vmss update -n {vmssName} -g {rgName} --instance-id {vmssVmName} --protectFromScaleIn

Minimum API Version Required

2023-09-01

Swagger PR link / SDK link

Azure/azure-rest-api-specs#26270

Request Example

NA

Target Date

2024-01-10

PM Contact

@BhawanaRaj

Engineer Contact

@mannanbansal

Additional context

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Compute az vm/vmss/image/disk/snapshot label Dec 21, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 21, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 21, 2023

Thank you for opening this issue, we will look into it.

@yanzhudd
Copy link
Contributor

Target Date
2024-01-10

Hi @mannanbansal,
please note that we would have a code freeze on 12-26 for the release of this sprint, and we don't have extra time to develop this feature. May I ask if the next release train (02-06) is acceptable to you?

@mannanbansal
Copy link
Author

Thanks Yan for reverting, yeah we are fine with next release train on 02/06.

@yonzhan yonzhan added this to the January 2024 (2024-02-06) milestone Dec 21, 2023
@yonzhan yonzhan removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Dec 21, 2023
@yanzhudd
Copy link
Contributor

yanzhudd commented Jan 8, 2024

PR: #28078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants