Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITrace Perf Optimizations #2187

Closed
bchong95 opened this issue Feb 4, 2021 · 2 comments
Closed

ITrace Perf Optimizations #2187

bchong95 opened this issue Feb 4, 2021 · 2 comments
Assignees
@sboshra
Labels
Diagnostics Issues around diagnostics and troubleshooting Hotfix A hotfix is required for the issue Performance

Comments

@bchong95
Copy link
Contributor

bchong95 commented Feb 4, 2021

ITrace Perf Optimizations

  • object pooling
  • lazy allocation for lists of size greater than or equal to 2
  • Keep reference to StoreResult without response Stream to avoid .ToString() allocation.
@bchong95 bchong95 mentioned this issue Feb 4, 2021
Merged
@j82w j82w added Hotfix A hotfix is required for the issue QUERY labels Feb 5, 2021
@j82w
Copy link
Contributor

j82w commented Feb 8, 2021 •
edited
Loading

8.85385% drop in throughput from ITrace library based on the perf runner (12915 Rps to 11820 Rps).
22.3778% increase in latency from ITrace library based on the perf runner (8.67ms to 10.5ms).

Blue line is PR #2097
itracelatency
itracerps

@bchong95 bchong95 added Diagnostics Issues around diagnostics and troubleshooting Performance and removed Hotfix A hotfix is required for the issue QUERY labels Feb 9, 2021
@j82w j82w added the Hotfix A hotfix is required for the issue label Feb 17, 2021
@j82w
Copy link
Contributor

j82w commented Feb 17, 2021

This was mostly fixed in #2204. The new runs shows roughly 2% regression.

@j82w j82w closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sboshra sboshra

Labels
Diagnostics Issues around diagnostics and troubleshooting Hotfix A hotfix is required for the issue Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bchong95 @j82w @sboshra