Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ClientTelemetry] Client telemetry tests are flaky #4731

Open
neildsh opened this issue Sep 27, 2024 · 3 comments
Open

[ClientTelemetry] Client telemetry tests are flaky #4731

neildsh opened this issue Sep 27, 2024 · 3 comments
Assignees

Comments

@neildsh
Copy link
Contributor

neildsh commented Sep 27, 2024

ClientTelemetryTestsBase has logic that is timing dependent. This causes the tests to be flaky.
The test also appears to be making real network requests, presumably to a server outside the node that tests run on.
Ideally, the WaitAndAssert method should be rewritten to correct these deficiencies.

To Reproduce
This reproduces in the PR builds.

Expected behavior
Tests should not use calls to Task.Delay or make network requests outside the node that they run on. The outcome of a test should be deterministic.

@kirankumarkolli
Copy link
Member

@sourabh1007 can you please take a look?

@Pilchie
Copy link
Member

Pilchie commented Sep 30, 2024

👀

@Pilchie
Copy link
Member

Pilchie commented Sep 30, 2024

If we can't prioritize this and identify a fix within this week, we should disable these tests until we can. It unduly impacts the productivity of the entire team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants