Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sender interface definition of SendBatch does not match actual SendBatch implementation method header definition #256

Open
burkconnor opened this issue May 20, 2022 · 0 comments
Open

Sender interface definition of SendBatch does not match actual SendBatch implementation method header definition #256

burkconnor opened this issue May 20, 2022 · 0 comments

Comments

@burkconnor
Copy link

Expected Behavior

The Sender interface should have the same method header definition for the SendBatch method as the implementation of the SendBatch method.

interface definition: SendBatch(ctx context.Context, iterator BatchIterator, opts ...BatchOption) error
implementation definition: SendBatch(ctx context.Context, iterator BatchIterator, opts ...BatchOption) error

Actual Behavior

interface definition: SendBatch(ctx context.Context, batch *EventBatch, opts ...SendOption) error
implementation definition: SendBatch(ctx context.Context, iterator BatchIterator, opts ...BatchOption) error

Environment

  • OS: MacOS v12.4
  • Go version: v1.18.2
  • Version of Library: v3.3.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@burkconnor