Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Node Version Source to Site Config setting over WEBSITE_NODE_DEFAULT_VERSION #221

Open
mhoeger opened this issue May 22, 2019 · 5 comments
Labels
App Service This would affect web apps as well as functions Needs: Attention 👋
Milestone

Comments

@mhoeger
Copy link
Contributor

mhoeger commented May 22, 2019

Backfilling values:

Option 1:

  • Copy current app setting and fill into website config, regardless of current website config value

Option 2:

  • Copy current app setting and fill into website config, regardless of current website config value
  • Delete app setting value? (NOTE: THIS RESTARTS SITE)

Option 3:

  • Explicitly null all website config values (wait until complete for all sites)
  • Copy current app setting and fill into website config

Updating from Portal, CLI, ARM:

Input
(If both, website_config takes priority.)

  • if (website_config): take website_config value
  • else if (app_setting): take app_setting value

Action
Option 1:

  • Save as both app setting and website config

Option 2 & 3:

  • Save as website config and actively remove app setting value

Reading node version for site start

Option 1:

  • Read app setting

Option 2:

  • if (app_setting): read app setting, because not yet updated
  • else if (website_config): read website config

Option 3:

  • if (website_config): read website config
  • else if (app_setting): read app setting
@mhoeger
Copy link
Contributor Author

mhoeger commented May 22, 2019

cc: @pragnagopa

@pragnagopa pragnagopa added this to the Triaged milestone May 23, 2019
@pragnagopa
Copy link
Member

cc @sanchitmehta fyi

@ejizba ejizba removed this from the Triaged milestone Nov 15, 2021
@ejizba
Copy link
Contributor

ejizba commented Jan 28, 2022

@pragnagopa can you give a short description of this issue and if any work still needs to be done?

@ghost
Copy link

ghost commented Feb 1, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@pragnagopa
Copy link
Member

@ejizba / @AnatoliB - Issue description already captured details on the work needed. This is part of the work needed to unify how node version is specified by Cx - as of now only Node version follows a different pattern - App Setting, rest of the languages rely on site config properties such as /javaVersion, /powershellVersion.

If you intend to drive this work forward either yourself or through App Services IDC team - please reach out offline and I can provide any missing details.

@ghost ghost removed the no recent activity label Feb 2, 2022
@ejizba ejizba removed the engineering label Mar 7, 2022
@ejizba ejizba added the App Service This would affect web apps as well as functions label Mar 16, 2022
@ejizba ejizba modified the milestones: Backlog Candidates, Tracking Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Service This would affect web apps as well as functions Needs: Attention 👋
Projects
None yet
Development

No branches or pull requests

3 participants