Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Create testing framework to run before changes are merged #102

Open
peytonr18 opened this issue Jul 11, 2024 · 1 comment
Open

[RFE] Create testing framework to run before changes are merged #102

peytonr18 opened this issue Jul 11, 2024 · 1 comment
Assignees
Labels
ci feature New feature or request

Comments

@peytonr18
Copy link
Contributor

Issue for creating some kind of testing framework or pipeline that can be used to ensure changes don't break the agent's functionality ahead of merging them into main.

Ideas discussed so far:

  1. Using a tool like mkosi to build an image locally , then run it as a VM and wiring that up to some IMDS server run locally and test functionality.
  2. Quite literally run the "manual" testing mechanism via some kind of github actions pipeline (spin up VM, run the changes and the image creation script, and then check to see that any VM created with the subsequent image provisions successfully)
@peytonr18 peytonr18 added the feature New feature or request label Jul 11, 2024
@jeremycline
Copy link
Member

It looks like https://github.com/systemd/mkosi provides a GitHub action and we could probably use https://github.com/systemd/systemd/blob/main/.github/workflows/mkosi.yml (and probably other workflows) as inspiration.

With #100 we can avoid using an IMDS server to start with and just mount an ISO on the virtual machine.

@dongsupark dongsupark added the ci label Jul 12, 2024
@vmarcella vmarcella self-assigned this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants