Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Manual code change after generation #1135

Open
weidongxu-microsoft opened this issue Mar 24, 2020 · 11 comments
Open

[BUG] Manual code change after generation #1135

weidongxu-microsoft opened this issue Mar 24, 2020 · 11 comments
Labels
Eng Mgmt Issues that refer to the management plane v2

Comments

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Mar 24, 2020

Collect manual change need to be done before generation (e.g. due to spec issue, better to fix spec).

Collect manual change need to be done after generation (e.g. due to spec issue, azure core bug, or generator bug).

Cmd line:

export SPEC_ROOT=/c/github/azure-rest-api-specs
export AUTOREST_JAVA=/c/github_fork/autorest.java

gulp codegen --projects features --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects policy --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA --preserve
gulp codegen --projects subscriptions --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA --preserve
gulp codegen --projects resources --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA --preserve

gulp codegen --projects storage --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA

gulp codegen --projects keyvault --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA

gulp codegen --projects graphrbac --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects authorization --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA --preserve

gulp codegen --projects msi --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA

gulp codegen --projects network --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects compute --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects appservice --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects containerregistry --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects containerservice --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects containerinstance --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects cosmos --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects dns --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects privatedns --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects monitor --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects sql --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects appplatform --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects redis --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects eventhubs --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects trafficmanager --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects servicebus --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
gulp codegen --projects cdn --spec-root $SPEC_ROOT --autorest-java $AUTOREST_JAVA
@weidongxu-microsoft weidongxu-microsoft added Mgmt Issues that refer to the management plane v2 labels Mar 24, 2020
@weidongxu-microsoft
Copy link
Member Author

weidongxu-microsoft commented Mar 24, 2020

Add 200 to

        @Post("/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/syncfunctiontriggers")
        @ExpectedResponses({200, 204})
        @UnexpectedResponseExceptionType(DefaultErrorResponseException.class)
        Mono<Response<Void>> syncFunctionTriggers(@HostParam("$host") String host, @PathParam("resourceGroupName") String resourceGroupName, @PathParam("name") String name, @PathParam("subscriptionId") String subscriptionId, @QueryParam("api-version") String apiVersion);

due to service bug.

@yungezz yungezz added the v2 Preview Blocker V2 Preview Blocker label Mar 24, 2020
@yungezz yungezz removed the v2 Preview Blocker V2 Preview Blocker label Apr 7, 2020
@xseeseesee
Copy link
Contributor

xseeseesee commented Apr 15, 2020

compute

Add below annotation

@JsonInclude(content = JsonInclude.Include.ALWAYS)

for the property userAssignedIdentities in class VirtualMachineIdentity and VirtualMachineScaleSetIdentity.

Need to check overloadings for class {resource}sInner when new enum types generated for query parameters. This might impact the URIs we send in the requests.

The naming of properties.type inside VirtualMachineExtensionInner need to rename with virtualMachineExtensionType instead of typePropertiesType.

Replace GalleryArtifactPublishingProfileBase with GalleryImageVersionPublishingProfile in GalleryImageVersionInner.

@weidongxu-microsoft

This comment has been minimized.

@weidongxu-microsoft
Copy link
Member Author

@weidongxu-microsoft

This comment has been minimized.

@xseeseesee
Copy link
Contributor

resources

remove operations in SubscriptionClient

@ChenTanyi

This comment has been minimized.

@weidongxu-microsoft
Copy link
Member Author

authorization

Change SharedAccessAuthorizationRuleResourceInner to extend Resource

@weidongxu-microsoft
Copy link
Member Author

weidongxu-microsoft commented Sep 16, 2020

servicebus

Change QueueResourceInner to extend Resource

Same for TopicResourceInner SubscriptionResourceInner

@xseeseesee

This comment has been minimized.

@weidongxu-microsoft

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Eng Mgmt Issues that refer to the management plane v2
Projects
None yet
Development

No branches or pull requests

4 participants