From 3fb3861d13f3bd26d54aa9a3618ed6e6e290a556 Mon Sep 17 00:00:00 2001
From: agalerrotaru <86316103+agalerrotaru@users.noreply.github.com>
Date: Thu, 10 Feb 2022 03:12:50 +0100
Subject: [PATCH] Adding xms-ids for CommonTypes (#17629)

* Adding xms-ids for CommonTypes

* corrections after rebase
---
 .../common-types/resource-management/v1/types.json        | 8 ++++++++
 .../common-types/resource-management/v2/types.json        | 8 ++++----
 .../common-types/resource-management/v3/types.json        | 8 ++++++++
 specification/common-types/rfcs/rfc7517.json              | 3 ++-
 4 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/specification/common-types/resource-management/v1/types.json b/specification/common-types/resource-management/v1/types.json
index 8a817487e2b9..71216592bf7c 100644
--- a/specification/common-types/resource-management/v1/types.json
+++ b/specification/common-types/resource-management/v1/types.json
@@ -308,6 +308,10 @@
           "items": {
             "$ref": "#/definitions/ErrorResponse"
           },
+          "x-ms-identifiers": [
+            "message",
+            "target"
+          ],
           "description": "The error details."
         },
         "additionalInfo": {
@@ -316,6 +320,7 @@
           "items": {
             "$ref": "#/definitions/ErrorAdditionalInfo"
           },
+          "x-ms-identifiers": [],
           "description": "The error additional info."
         }
       }
@@ -414,6 +419,9 @@
           "items": {
             "$ref": "#/definitions/Operation"
           },
+          "x-ms-identifiers": [
+            "name"
+          ],
           "description": "List of operations supported by the resource provider",
           "readOnly": true
         },
diff --git a/specification/common-types/resource-management/v2/types.json b/specification/common-types/resource-management/v2/types.json
index 1d038e171519..a1d7f19f1588 100644
--- a/specification/common-types/resource-management/v2/types.json
+++ b/specification/common-types/resource-management/v2/types.json
@@ -307,11 +307,11 @@
           "items": {
             "$ref": "#/definitions/ErrorDetail"
           },
-          "description": "The error details.",
           "x-ms-identifiers": [
             "message",
             "target"
-          ]
+          ],
+          "description": "The error details."
         },
         "additionalInfo": {
           "readOnly": true,
@@ -319,8 +319,8 @@
           "items": {
             "$ref": "#/definitions/ErrorAdditionalInfo"
           },
-          "description": "The error additional info.",
-          "x-ms-identifiers": []
+          "x-ms-identifiers": [],
+          "description": "The error additional info."
         }
       }
     },
diff --git a/specification/common-types/resource-management/v3/types.json b/specification/common-types/resource-management/v3/types.json
index 3785f8b346c7..f7a519b41239 100644
--- a/specification/common-types/resource-management/v3/types.json
+++ b/specification/common-types/resource-management/v3/types.json
@@ -316,6 +316,10 @@
           "items": {
             "$ref": "#/definitions/ErrorDetail"
           },
+          "x-ms-identifiers": [
+            "message",
+            "target"
+          ],
           "description": "The error details."
         },
         "additionalInfo": {
@@ -324,6 +328,7 @@
           "items": {
             "$ref": "#/definitions/ErrorAdditionalInfo"
           },
+          "x-ms-identifiers": [],
           "description": "The error additional info."
         }
       }
@@ -433,6 +438,9 @@
           "items": {
             "$ref": "#/definitions/Operation"
           },
+          "x-ms-identifiers": [
+            "name"
+          ],
           "description": "List of operations supported by the resource provider",
           "readOnly": true
         },
diff --git a/specification/common-types/rfcs/rfc7517.json b/specification/common-types/rfcs/rfc7517.json
index 1456a46331cc..c1032a754504 100644
--- a/specification/common-types/rfcs/rfc7517.json
+++ b/specification/common-types/rfcs/rfc7517.json
@@ -93,7 +93,8 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/JSONWebKey"
-          }
+          },
+          "x-ms-identifiers": []
         }
       }
     }