Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Fabrid] 8.2 spec #16530

Closed
markweitzel opened this issue Oct 25, 2021 · 3 comments · Fixed by #16498
Closed

[Service Fabrid] 8.2 spec #16530

markweitzel opened this issue Oct 25, 2021 · 3 comments · Fixed by #16498
Assignees
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes.

Comments

@markweitzel
Copy link
Member

markweitzel commented Oct 25, 2021

Service name : Service Fabric
Key contact for the review : Jeffrey Jarry (jejarry)
Whether this is a new or existing API : Existing API with new version
Whether or not your service already been deployed : Yes
A brief description of the material to be reviewed/changed : A small subset of our API has been updated with new fields
A link to the PR/issue in the azure-rest-api-specs (public) or azure/azure-rest-api-specs-pr (private) repo #16498

@markweitzel markweitzel added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Oct 25, 2021
@markweitzel markweitzel self-assigned this Oct 25, 2021
@markweitzel markweitzel linked a pull request Oct 25, 2021 that will close this issue
25 tasks
@raych1 raych1 assigned mikekistler and unassigned raych1 Nov 2, 2021
@markweitzel
Copy link
Member Author

markweitzel commented Nov 3, 2021

API Stewardship Board Review: 3-Nov-21

Because this is an existing service, there will be little impact that we will be able to make, in part b/c we want to be consistent with the entirety of the service. The changes in this version are small, only one new operation and adding minor updates to the others.

Actions & Next Steps

@jeffj6123 to connect with @mikekistler to learn about Spectral and potentially build a ruleset specifically for Service Fabric

Link to recording
Internal MS link

@markweitzel markweitzel added APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. and removed APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. labels Nov 3, 2021
@jeffj6123
Copy link
Contributor

@markweitzel is this PR ok to be merged?

@markweitzel
Copy link
Member Author

@jeffj6123 -- From the perspective of the API Stewardship Board, yes. The Azure SDK team may have a few separate concerns as well though. Note: I do not have commit rights on this repo so we will need to coordinate with @lmazuel and team. Happy to help there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants