Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing string type for ManagedServiceIdentity enum #2344

Closed
gunzip opened this issue Jan 26, 2018 · 3 comments
Closed

Missing string type for ManagedServiceIdentity enum #2344

gunzip opened this issue Jan 26, 2018 · 3 comments
Assignees

Comments

@gunzip
Copy link

gunzip commented Jan 26, 2018

It looks like there is a missing typedef in swagger specs of ManagedServiceIdentity:

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2016-03-01/CommonDefinitions.json#L1038

This breaks the go SDK that expects a map while the output of the identity field is a plain string:

{
     .....
    "kind": "app",
  },
  "identity": {
    "type": "SystemAssigned",
    "tenantId": "....",
    "principalId": "......"
  }
}

see also
Azure/azure-sdk-for-go#992 (comment)

@dsgouda
Copy link
Contributor

dsgouda commented Jan 26, 2018

Tagging @naveedaz since he last worked on this spec

@dsgouda dsgouda assigned naveedaz and unassigned dsgouda Jan 26, 2018
@jhendrixMSFT
Copy link
Member

Ping @naveedaz

@jhendrixMSFT
Copy link
Member

Spec has been fixed, will get rolled up into next major release of Go SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants