Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logic] Model validation fails with errors #778

Closed
veronicagg opened this issue Nov 30, 2016 · 3 comments
Closed

[Logic] Model validation fails with errors #778

veronicagg opened this issue Nov 30, 2016 · 3 comments
Assignees
Labels
internal-ms Logic App P1 Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@veronicagg
Copy link
Contributor

veronicagg commented Nov 30, 2016

Model validation reports erros when validating responses against .net tests recordings for logic 2015-08-01 spec:
> Operation: IntegrationAccountAgreements_List
> x-ms-examples
> Scenario: ListIntegrationAccountAgreementsGET115
> InnerErrors:
3. code: ENUM_MISMATCH
message: No enum match for: EDIFACT
path: value,1,properties,agreementType

> Operation: IntegrationAccountSchemas_CreateOrUpdate
	> x-ms-examples
		> Scenario: CreateAndDeleteIntegrationAccountSchemaPUT62
			> InnerErrors:
			  1. code: INVALID_TYPE
			     message: Expected type object but found type string
			     path: properties,metadata
			     description: The metadata.
			  2. code: INVALID_TYPE
			     message: Expected type object but found type string
			     path: properties,content
			     description: The content.

From swagger:

    "AgreementType": {
      "type": "string",
      "enum": [
        "NotSpecified",
        "AS2",
        "X12",
        "Edifact"
      ],
      "x-ms-enum": {
        "name": "AgreementType",
        "modelAsString": false
      }
    },
  "IntegrationAccountSchemaProperties": {
      "type": "object",
      "properties": {
        "schemaType": {
          "$ref": "#/definitions/SchemaType",
          "description": "The schema type."
        },
        "targetNamespace": {
          "type": "string",
          "description": "The target namespace."
        },
        "createdTime": {
          "type": "string",
          "format": "date-time",
          "readOnly": true,
          "description": "The created time."
        },
        "changedTime": {
          "type": "string",
          "format": "date-time",
          "readOnly": true,
          "description": "The changed time."
        },
        "content": {
          "type": "object",
          "description": "The content.",
          "properties": {}
        },
        "contentType": {
          "type": "string",
          "description": "The content type."
        },
        "contentLink": {
          "$ref": "#/definitions/IntegrationAccountContentLink",
          "readOnly": true,
          "description": "The content link."
        },
        "metadata": {
          "type": "object",
          "description": "The metadata.",
          "properties": {}
        }
      }
    },

Other models in the spec containing 'metadata' and 'content' show similar issue.

> Operation: Workflows_Validate
	> x-ms-examples
		> Scenario: ValidateWorkflowPOST203
			> InnerErrors:
			  1. code: INVALID_TYPE
			     message: Expected type object but found type string
			     path: properties,definition

Also for logic 2016 spec:

        "definition": {
          "$ref": "#/definitions/Object",
          "description": "The definition."
        },
@pankajsn
Copy link
Contributor

@kirthik already fixed

@kirthik
Copy link
Contributor

kirthik commented Jun 9, 2017

@pankajsn - Could you please provide the commit id?

@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
@salameer
Copy link
Member

salameer commented Oct 9, 2018

closing and if not fixed this would blocked at a PR level as specs are being updated

@salameer salameer closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-ms Logic App P1 Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

8 participants