From e9339b3ecfe221b54bc99695af05740c3ea27c75 Mon Sep 17 00:00:00 2001 From: Sachin Doddaiah Shylaja Date: Tue, 8 Sep 2020 20:18:01 -0700 Subject: [PATCH 1/5] change to sub resource. List to include VmssVm extension --- .../stable/2020-06-01/compute.json | 54 ++++++++++++++++--- 1 file changed, 47 insertions(+), 7 deletions(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json index 817f4c62ac26..98b5e5017411 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json +++ b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json @@ -5174,7 +5174,7 @@ "in": "body", "required": true, "schema": { - "$ref": "#/definitions/VirtualMachineExtension" + "$ref": "#/definitions/VirtualMachineScaleSetVMExtension" }, "description": "Parameters supplied to the Create Virtual Machine Extension operation." }, @@ -5189,13 +5189,13 @@ "200": { "description": "OK", "schema": { - "$ref": "#/definitions/VirtualMachineExtension" + "$ref": "#/definitions/VirtualMachineScaleSetVMExtension" } }, "201": { "description": "Created", "schema": { - "$ref": "#/definitions/VirtualMachineExtension" + "$ref": "#/definitions/VirtualMachineScaleSetVMExtension" } }, "default": { @@ -5252,7 +5252,7 @@ "in": "body", "required": true, "schema": { - "$ref": "#/definitions/VirtualMachineExtensionUpdate" + "$ref": "#/definitions/VirtualMachineScaleSetVMExtensionUpdate" }, "description": "Parameters supplied to the Update Virtual Machine Extension operation." }, @@ -5267,7 +5267,7 @@ "200": { "description": "OK", "schema": { - "$ref": "#/definitions/VirtualMachineExtension" + "$ref": "#/definitions/VirtualMachineScaleSetVMExtension" } }, "default": { @@ -5403,7 +5403,7 @@ "200": { "description": "OK", "schema": { - "$ref": "#/definitions/VirtualMachineExtension" + "$ref": "#/definitions/VirtualMachineScaleSetVMExtension" } }, "default": { @@ -5467,7 +5467,7 @@ "200": { "description": "OK", "schema": { - "$ref": "#/definitions/VirtualMachineExtensionsListResult" + "$ref": "#/definitions/VirtualMachineScaleSetVMExtensionsListResult" } }, "default": { @@ -7335,6 +7335,20 @@ ], "description": "Describes a Virtual Machine Extension." }, + "VirtualMachineScaleSetVMExtension": { + "properties": { + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/VirtualMachineExtensionProperties" + } + }, + "allOf": [ + { + "$ref": "#/definitions/SubResourceReadOnly" + } + ], + "description": "Describes a VMSS VM Extension." + }, "VirtualMachineExtensionUpdate": { "properties": { "properties": { @@ -7349,6 +7363,20 @@ ], "description": "Describes a Virtual Machine Extension." }, + "VirtualMachineScaleSetVMExtensionUpdate": { + "properties": { + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/VirtualMachineExtensionUpdateProperties" + } + }, + "allOf": [ + { + "$ref": "#/definitions/SubResourceReadOnly" + } + ], + "description": "Describes a VMSS VM Extension." + }, "VirtualMachineExtensionsListResult": { "properties": { "value": { @@ -7361,6 +7389,18 @@ }, "description": "The List Extension operation response" }, + "VirtualMachineScaleSetVMExtensionsListResult": { + "properties": { + "value": { + "type": "array", + "items": { + "$ref": "#/definitions/VirtualMachineScaleSetVMExtension" + }, + "description": "The list of VMSS VM extensions" + } + }, + "description": "The List VMSS VM Extension operation response" + }, "VirtualMachineSoftwarePatchProperties": { "properties": { "patchId": { From 76279ad721d6f831916952826c99b6b75994764e Mon Sep 17 00:00:00 2001 From: Sachin Doddaiah Shylaja Date: Wed, 9 Sep 2020 09:46:56 -0700 Subject: [PATCH 2/5] remove location from example --- .../CreateOrUpdateVirtualMachineScaleSetVMExtensions.json | 3 --- .../examples/GetVirtualMachineScaleSetVMExtensions.json | 1 - .../examples/ListVirtualMachineScaleSetVMExtensions.json | 2 -- 3 files changed, 6 deletions(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/CreateOrUpdateVirtualMachineScaleSetVMExtensions.json b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/CreateOrUpdateVirtualMachineScaleSetVMExtensions.json index 5e3dbf00975a..40185d51f90e 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/CreateOrUpdateVirtualMachineScaleSetVMExtensions.json +++ b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/CreateOrUpdateVirtualMachineScaleSetVMExtensions.json @@ -7,7 +7,6 @@ "vmExtensionName": "myVMExtension", "api-version": "2020-06-01", "extensionParameters": { - "location": "westus", "properties": { "autoUpgradeMinorVersion": true, "publisher": "extPublisher", @@ -23,7 +22,6 @@ "201": { "body": { "name": "myVMExtension", - "location": "westus", "type": "Microsoft.Compute/virtualMachineScaleSets/virtualMachines/extensions", "id": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachineScaleSets/myvmScaleSet/virtualMachines/0/extensions/myVMExtension", "properties": { @@ -41,7 +39,6 @@ "200": { "body": { "name": "myVMExtension", - "location": "westus", "type": "Microsoft.Compute/virtualMachineScaleSets/virtualMachines/extensions", "id": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachineScaleSets/myvmScaleSet/virtualMachines/0/extensions/myVMExtension", "properties": { diff --git a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/GetVirtualMachineScaleSetVMExtensions.json b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/GetVirtualMachineScaleSetVMExtensions.json index 2c27ae1e263c..fbba0cdbf56c 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/GetVirtualMachineScaleSetVMExtensions.json +++ b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/GetVirtualMachineScaleSetVMExtensions.json @@ -21,7 +21,6 @@ } }, "name": "myVMExtension", - "location": "westus", "type": "Microsoft.Compute/virtualMachineScaleSets/virtualMachines/extensions", "id": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachineScaleSets/myvmScaleSet/virtualMachines/0/extensions/myVMExtension" } diff --git a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/ListVirtualMachineScaleSetVMExtensions.json b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/ListVirtualMachineScaleSetVMExtensions.json index f2120acb750a..f670b23fd41d 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/ListVirtualMachineScaleSetVMExtensions.json +++ b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/ListVirtualMachineScaleSetVMExtensions.json @@ -22,7 +22,6 @@ } }, "name": "myVMExtension", - "location": "westus", "type": "Microsoft.Compute/virtualMachineScaleSets/virtualMachines/extensions", "id": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachineScaleSets/myvmScaleSet/virtualMachines/0/extensions/myVMExtension" }, @@ -38,7 +37,6 @@ } }, "name": "myVMExtension1", - "location": "westus", "type": "Microsoft.Compute/virtualMachineScaleSets/virtualMachines/extensions", "id": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachineScaleSets/myvmScaleSet/virtualMachines/0/extensions/myVMExtension1" } From 1bc134e61838ad158947963bc3f8f59fcc3665af Mon Sep 17 00:00:00 2001 From: Sachin Doddaiah Shylaja Date: Wed, 9 Sep 2020 10:20:31 -0700 Subject: [PATCH 3/5] add name and type --- .../stable/2020-06-01/compute.json | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json index 98b5e5017411..ca53482c104a 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json +++ b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json @@ -7337,6 +7337,15 @@ }, "VirtualMachineScaleSetVMExtension": { "properties": { + "name": { + "type": "string", + "description": "The name of the extension." + }, + "type": { + "readOnly": true, + "type": "string", + "description": "Resource type" + }, "properties": { "x-ms-client-flatten": true, "$ref": "#/definitions/VirtualMachineExtensionProperties" @@ -7365,6 +7374,16 @@ }, "VirtualMachineScaleSetVMExtensionUpdate": { "properties": { + "name": { + "readOnly": true, + "type": "string", + "description": "The name of the extension." + }, + "type": { + "readOnly": true, + "type": "string", + "description": "Resource type" + }, "properties": { "x-ms-client-flatten": true, "$ref": "#/definitions/VirtualMachineExtensionUpdateProperties" From 176fb8294b5144a904d3a02afb4a14bee8ec11b2 Mon Sep 17 00:00:00 2001 From: Sachin Doddaiah Shylaja Date: Fri, 11 Sep 2020 16:25:00 -0700 Subject: [PATCH 4/5] make name readonly --- .../Microsoft.Compute/stable/2020-06-01/compute.json | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json index ca53482c104a..515bc9a3b6bd 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json +++ b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json @@ -7338,6 +7338,7 @@ "VirtualMachineScaleSetVMExtension": { "properties": { "name": { + "readOnly": true, "type": "string", "description": "The name of the extension." }, From 9dc9f369a46f8eac34b8a771b3697e2887d507e3 Mon Sep 17 00:00:00 2001 From: Sachin Doddaiah Shylaja Date: Thu, 1 Oct 2020 11:07:15 -0700 Subject: [PATCH 5/5] remove location --- .../examples/UpdateVirtualMachineScaleSetVMExtensions.json | 1 - 1 file changed, 1 deletion(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/UpdateVirtualMachineScaleSetVMExtensions.json b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/UpdateVirtualMachineScaleSetVMExtensions.json index 659ea562168a..c1a159448f23 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/UpdateVirtualMachineScaleSetVMExtensions.json +++ b/specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/examples/UpdateVirtualMachineScaleSetVMExtensions.json @@ -22,7 +22,6 @@ "200": { "body": { "name": "myVMExtension", - "location": "westus", "type": "Microsoft.Compute/virtualMachineScaleSets/virtualMachines/extensions", "id": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachineScaleSets/myvmScaleSet/virtualMachines/0/extensions/myVMExtension", "properties": {