From c3609eebcddba17959c15f15bef6b39260c5117d Mon Sep 17 00:00:00 2001 From: Yoram Singer Date: Tue, 26 Jan 2021 17:16:15 +0200 Subject: [PATCH 1/3] Swagger correctness fixes --- .../2020-02-02-preview/components_API.json | 62 ++++++++++++++++++- 1 file changed, 59 insertions(+), 3 deletions(-) diff --git a/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json b/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json index 574b88250e5d..5ace08eaace0 100644 --- a/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json +++ b/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json @@ -52,6 +52,12 @@ "schema": { "$ref": "#/definitions/ApplicationInsightsComponentListResult" } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" + } } }, "x-ms-examples": { @@ -84,6 +90,12 @@ "description": "A list containing 0 or more Application Insights component definitions.", "schema": { "$ref": "#/definitions/ApplicationInsightsComponentListResult" + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" + } } } }, @@ -121,6 +133,12 @@ }, "204": { "description": "The specified component does not exist." + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" + } } }, "x-ms-examples": { @@ -152,6 +170,12 @@ "schema": { "$ref": "#/definitions/ApplicationInsightsComponent" } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" + } } }, "x-ms-examples": { @@ -192,6 +216,12 @@ "schema": { "$ref": "#/definitions/ApplicationInsightsComponent" } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" + } } }, "x-ms-examples": { @@ -235,6 +265,12 @@ "schema": { "$ref": "#/definitions/ApplicationInsightsComponent" } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" + } } }, "x-ms-examples": { @@ -271,6 +307,12 @@ "schema": { "$ref": "#/definitions/ComponentPurgeResponse" } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" + } } }, "x-ms-examples": { @@ -307,6 +349,12 @@ "schema": { "$ref": "#/definitions/ComponentPurgeStatusResponse" } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" + } } }, "x-ms-examples": { @@ -373,6 +421,10 @@ "type": "string", "description": "The kind of application that this component refers to, used to customize UI. This value is a freeform string, values should typically be one of the following: web, ios, other, store, java, phone." }, + "etag": { + "type": "string", + "description": "Resource etag" + }, "properties": { "x-ms-client-flatten": true, "description": "Properties that define an Application Insights component resource.", @@ -402,6 +454,11 @@ "readOnly": true, "description": "Application Insights Unique ID for your Application." }, + "Name": { + "type": "string", + "readOnly": true, + "description": "Application name." + }, "Application_Type": { "type": "string", "description": "Type of application being monitored.", @@ -507,7 +564,7 @@ }, "WorkspaceResourceId": { "type": "string", - "description": "ResourceId of the log analytics workspace which the data will be ingested to." + "description": "Resource Id of the log analytics workspace which the data will be ingested to. This property is required to create an application with this API version. Applications from older versions will not have this property." }, "LaMigrationDate": { "type": "string", @@ -547,8 +604,7 @@ } }, "required": [ - "Application_Type", - "WorkspaceResourceId" + "Application_Type" ] }, "PrivateLinkScopedResource": { From a1b01e6ca93e09e77dcb77b8f4ac624c4b0ff808 Mon Sep 17 00:00:00 2001 From: Yoram Singer Date: Tue, 26 Jan 2021 18:16:06 +0200 Subject: [PATCH 2/3] Fix --- .../preview/2020-02-02-preview/components_API.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json b/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json index 5ace08eaace0..eae691b48f6e 100644 --- a/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json +++ b/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json @@ -90,12 +90,12 @@ "description": "A list containing 0 or more Application Insights component definitions.", "schema": { "$ref": "#/definitions/ApplicationInsightsComponentListResult" - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" - } + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" } } }, From 953f281cc5b0cacd894f81339c39d1e3f5d5bd31 Mon Sep 17 00:00:00 2001 From: Yoram Singer Date: Wed, 27 Jan 2021 11:14:12 +0200 Subject: [PATCH 3/3] Prettier fix --- .../preview/2020-02-02-preview/components_API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json b/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json index eae691b48f6e..d890209a607b 100644 --- a/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json +++ b/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2020-02-02-preview/components_API.json @@ -90,7 +90,7 @@ "description": "A list containing 0 or more Application Insights component definitions.", "schema": { "$ref": "#/definitions/ApplicationInsightsComponentListResult" - } + } }, "default": { "description": "Error response describing why the operation failed.",