From 3ee960d2c0273110daac3a17e7b4f8753cce2054 Mon Sep 17 00:00:00 2001
From: rakeshrana44 <73717426+rakeshrana44@users.noreply.github.com>
Date: Mon, 7 Jun 2021 18:57:17 -0700
Subject: [PATCH 1/6] update description of filter and metric names
update description of filter and metric names
---
.../Microsoft.Insights/stable/2018-01-01/metrics_API.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-01-01/metrics_API.json b/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-01-01/metrics_API.json
index 8f531f663b66..06bbce38a107 100644
--- a/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-01-01/metrics_API.json
+++ b/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-01-01/metrics_API.json
@@ -69,7 +69,7 @@
"name": "$filter",
"in": "query",
"type": "string",
- "description": "The **$filter** is used to reduce the set of metric data returned.
Example:
Metric contains metadata A, B and C.
- Return all time series of C where A = a1 and B = b1 or b2
**$filter=A eq ‘a1’ and B eq ‘b1’ or B eq ‘b2’ and C eq ‘*’**
- Invalid variant:
**$filter=A eq ‘a1’ and B eq ‘b1’ and C eq ‘*’ or B = ‘b2’**
This is invalid because the logical or operator cannot separate two different metadata names.
- Return all time series where A = a1, B = b1 and C = c1:
**$filter=A eq ‘a1’ and B eq ‘b1’ and C eq ‘c1’**
- Return all time series where A = a1
**$filter=A eq ‘a1’ and B eq ‘*’ and C eq ‘*’**.",
+ "description": "The **$filter** is used to reduce the set of metric data returned. Example: Metric contains metadata A, B and C. - Return all time series of C where A = a1 and B = b1 or b2 **$filter=A eq 'a1' and B eq 'b1' or B eq 'b2' and C eq '*'** - Invalid variant: **$filter=A eq 'a1' and B eq 'b1' and C eq '*' or B = 'b2'** This is invalid because the logical or operator cannot separate two different metadata names. - Return all time series where A = a1, B = b1 and C = c1: **$filter=A eq 'a1' and B eq 'b1' and C eq 'c1'** - Return all time series where A = a1 **$filter=A eq 'a1' and B eq '*' and C eq '*'**. Special case: When dimension name or dimension value uses round brackets. Eg: When dimension name is **dim (test) 1** Instead of using $filter= \"dim (test) 1 eq '*' \" use **$filter= \"dim %2528test%2529 1 eq '*' \"** When dimension name is **dim (test) 3** and dimension value is **dim3 (test) val** Instead of using $filter= \"dim (test) 3 eq 'dim3 (test) val' \" use **$filter= \"dim %2528test%2529 3 eq 'dim3 %2528test%2529 val' \"**",
"required": false
},
{
@@ -351,7 +351,7 @@
"in": "query",
"required": false,
"type": "string",
- "description": "The names of the metrics (comma separated) to retrieve.",
+ "description": "The names of the metrics (comma separated) to retrieve. Special case: If a metricname itself has a comma in it then use %2 to indicate it. Eg: 'Metric,Name1' should be **'Metric%2Name1'**",
"x-ms-parameter-location": "method"
},
"AggregationsParameter": {
From 20fa0f525a1994995ca0b87e43137f1e8cea40d9 Mon Sep 17 00:00:00 2001
From: rakeshrana44 <73717426+rakeshrana44@users.noreply.github.com>
Date: Tue, 8 Jun 2021 17:05:27 -0700
Subject: [PATCH 2/6] update metricBaselines_API filter & metricnames
update metricBaselines_API filter & metricnames
---
.../stable/2019-03-01/metricBaselines_API.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/specification/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/metricBaselines_API.json b/specification/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/metricBaselines_API.json
index af1167214569..26456cf38c73 100644
--- a/specification/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/metricBaselines_API.json
+++ b/specification/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/metricBaselines_API.json
@@ -78,7 +78,7 @@
"name": "$filter",
"in": "query",
"type": "string",
- "description": "The **$filter** is used to reduce the set of metric data returned.
Example:
Metric contains metadata A, B and C.
- Return all time series of C where A = a1 and B = b1 or b2
**$filter=A eq ‘a1’ and B eq ‘b1’ or B eq ‘b2’ and C eq ‘*’**
- Invalid variant:
**$filter=A eq ‘a1’ and B eq ‘b1’ and C eq ‘*’ or B = ‘b2’**
This is invalid because the logical or operator cannot separate two different metadata names.
- Return all time series where A = a1, B = b1 and C = c1:
**$filter=A eq ‘a1’ and B eq ‘b1’ and C eq ‘c1’**
- Return all time series where A = a1
**$filter=A eq ‘a1’ and B eq ‘*’ and C eq ‘*’**.",
+ "description": "The **$filter** is used to reduce the set of metric data returned. Example: Metric contains metadata A, B and C. - Return all time series of C where A = a1 and B = b1 or b2 **$filter=A eq 'a1' and B eq 'b1' or B eq 'b2' and C eq '*'** - Invalid variant: **$filter=A eq 'a1' and B eq 'b1' and C eq '*' or B = 'b2'** This is invalid because the logical or operator cannot separate two different metadata names. - Return all time series where A = a1, B = b1 and C = c1: **$filter=A eq 'a1' and B eq 'b1' and C eq 'c1'** - Return all time series where A = a1 **$filter=A eq 'a1' and B eq '*' and C eq '*'**. Special case: When dimension name or dimension value uses round brackets. Eg: When dimension name is **dim (test) 1** Instead of using $filter= \"dim (test) 1 eq '*' \" use **$filter= \"dim %2528test%2529 1 eq '*' \"** When dimension name is **dim (test) 3** and dimension value is **dim3 (test) val** Instead of using $filter= \"dim (test) 3 eq 'dim3 (test) val' \" use **$filter= \"dim %2528test%2529 3 eq 'dim3 %2528test%2529 val' \"**",
"required": false
},
{
@@ -353,7 +353,7 @@
"in": "query",
"required": false,
"type": "string",
- "description": "Metric namespace to query metric definitions for.",
+ "description": "The names of the metrics (comma separated) to retrieve. Special case: If a metricname itself has a comma in it then use %2 to indicate it. Eg: 'Metric,Name1' should be **'Metric%2Name1'**",
"x-ms-parameter-location": "method"
},
"AggregationsParameter": {
From eff129c5d77e85630e50cbaaecdfd44449cd5095 Mon Sep 17 00:00:00 2001
From: rakeshrana44 <73717426+rakeshrana44@users.noreply.github.com>
Date: Tue, 8 Jun 2021 17:07:22 -0700
Subject: [PATCH 3/6] update metricBaselines_API filter & metricnames
update metricBaselines_API with filter & metricnames
---
.../stable/2018-09-01/metricBaselines_API.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-09-01/metricBaselines_API.json b/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-09-01/metricBaselines_API.json
index cbf5493c2171..39a35c8d609e 100644
--- a/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-09-01/metricBaselines_API.json
+++ b/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-09-01/metricBaselines_API.json
@@ -78,7 +78,7 @@
"name": "$filter",
"in": "query",
"type": "string",
- "description": "The **$filter** is used to reduce the set of metric data returned.
Example:
Metric contains metadata A, B and C.
- Return all time series of C where A = a1 and B = b1 or b2
**$filter=A eq ‘a1’ and B eq ‘b1’ or B eq ‘b2’ and C eq ‘*’**
- Invalid variant:
**$filter=A eq ‘a1’ and B eq ‘b1’ and C eq ‘*’ or B = ‘b2’**
This is invalid because the logical or operator cannot separate two different metadata names.
- Return all time series where A = a1, B = b1 and C = c1:
**$filter=A eq ‘a1’ and B eq ‘b1’ and C eq ‘c1’**
- Return all time series where A = a1
**$filter=A eq ‘a1’ and B eq ‘*’ and C eq ‘*’**.",
+ "description": "The **$filter** is used to reduce the set of metric data returned. Example: Metric contains metadata A, B and C. - Return all time series of C where A = a1 and B = b1 or b2 **$filter=A eq 'a1' and B eq 'b1' or B eq 'b2' and C eq '*'** - Invalid variant: **$filter=A eq 'a1' and B eq 'b1' and C eq '*' or B = 'b2'** This is invalid because the logical or operator cannot separate two different metadata names. - Return all time series where A = a1, B = b1 and C = c1: **$filter=A eq 'a1' and B eq 'b1' and C eq 'c1'** - Return all time series where A = a1 **$filter=A eq 'a1' and B eq '*' and C eq '*'**. Special case: When dimension name or dimension value uses round brackets. Eg: When dimension name is **dim (test) 1** Instead of using $filter= \"dim (test) 1 eq '*' \" use **$filter= \"dim %2528test%2529 1 eq '*' \"** When dimension name is **dim (test) 3** and dimension value is **dim3 (test) val** Instead of using $filter= \"dim (test) 3 eq 'dim3 (test) val' \" use **$filter= \"dim %2528test%2529 3 eq 'dim3 %2528test%2529 val' \"**",
"required": false
},
{
@@ -334,7 +334,7 @@
"in": "query",
"required": false,
"type": "string",
- "description": "The names of the metrics (comma separated) to retrieve.",
+ "description": "The names of the metrics (comma separated) to retrieve. Special case: If a metricname itself has a comma in it then use %2 to indicate it. Eg: 'Metric,Name1' should be **'Metric%2Name1'**",
"x-ms-parameter-location": "method"
},
"MetricNamespaceParameter": {
From 390dff71535eced6668705416f3e326736791ad9 Mon Sep 17 00:00:00 2001
From: rakeshrana44 <73717426+rakeshrana44@users.noreply.github.com>
Date: Wed, 9 Jun 2021 00:26:59 -0700
Subject: [PATCH 4/6] correctly updating the changes
correctly updating the changes
---
.../stable/2019-03-01/metricBaselines_API.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/specification/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/metricBaselines_API.json b/specification/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/metricBaselines_API.json
index 26456cf38c73..42b89e85889e 100644
--- a/specification/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/metricBaselines_API.json
+++ b/specification/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/metricBaselines_API.json
@@ -345,7 +345,7 @@
"in": "query",
"required": false,
"type": "string",
- "description": "The names of the metrics (comma separated) to retrieve.",
+ "description": "The names of the metrics (comma separated) to retrieve. Special case: If a metricname itself has a comma in it then use %2 to indicate it. Eg: 'Metric,Name1' should be **'Metric%2Name1'**",
"x-ms-parameter-location": "method"
},
"MetricNamespaceParameter": {
@@ -353,7 +353,7 @@
"in": "query",
"required": false,
"type": "string",
- "description": "The names of the metrics (comma separated) to retrieve. Special case: If a metricname itself has a comma in it then use %2 to indicate it. Eg: 'Metric,Name1' should be **'Metric%2Name1'**",
+ "description": "Metric namespace to query metric definitions for.",
"x-ms-parameter-location": "method"
},
"AggregationsParameter": {
From 168deb606149541c6c42902dd965a4004d6ac55d Mon Sep 17 00:00:00 2001
From: rakeshrana44 <73717426+rakeshrana44@users.noreply.github.com>
Date: Wed, 9 Jun 2021 01:12:41 -0700
Subject: [PATCH 5/6] update description of metricNamesParameter
update description of metricNamesParameter
---
.../Microsoft.Insights/stable/2018-09-01/baseline_API.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-09-01/baseline_API.json b/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-09-01/baseline_API.json
index 1a9d8374b633..d2ba6d2ba226 100644
--- a/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-09-01/baseline_API.json
+++ b/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-09-01/baseline_API.json
@@ -440,7 +440,7 @@
"in": "query",
"required": false,
"type": "string",
- "description": "The names of the metrics (comma separated) to retrieve.",
+ "description": "The names of the metrics (comma separated) to retrieve. Special case: If a metricname itself has a comma in it then use %2 to indicate it. Eg: 'Metric,Name1' should be **'Metric%2Name1'**",
"x-ms-parameter-location": "method"
},
"AggregationParameter": {
From 6069236ebe0eeed16313c86a961d55b3a8ccb41d Mon Sep 17 00:00:00 2001
From: rakeshrana44 <73717426+rakeshrana44@users.noreply.github.com>
Date: Wed, 9 Jun 2021 01:21:10 -0700
Subject: [PATCH 6/6] adding word
adding word
---
custom-words.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/custom-words.txt b/custom-words.txt
index b912ee78b4e1..d2138957dce2 100644
--- a/custom-words.txt
+++ b/custom-words.txt
@@ -1109,6 +1109,7 @@ Metastores
Metric's
metricdefinitions
metricmetadata
+metricname
metricnames
metricnamespace
metricsadvisor