Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph swagger specs for version 1.6-internal #149

Merged
merged 2 commits into from
Feb 26, 2016

Conversation

shuagarw
Copy link
Contributor

Swagger specs for Graph Version 1.6-internal

@stankovski
Copy link
Member

I don't see SubscriptionIdParameter being used in the path. Why do you need this parameter?

@stankovski
Copy link
Member

All "patch" operations should be called Path (e.g. Application_Path) to avoid ambiguity.

@stankovski
Copy link
Member

Why is "post" called Group_GetMemberGroups

"/{tenantID}/groups/{objectId}/getMemberGroups": {
      "post": {
        "operationId": "Group_GetMemberGroups",

@amarzavery
Copy link
Contributor

We don't support external docs. Please add the link as a part of description. This will generate better documentation
"externalDocs": {
28 "url": "http://msdn.microsoft.com/en-us/library/azure/hh974476.aspx"
29 },

@brjohnstmsft
Copy link
Member

AutoRest should support externalDocs so that URLs can have special handling in the generated code: Azure/autorest#288

@amarzavery
Copy link
Contributor

Thanks Bruce, for filing the issue. We will support this very soon.

@shuagarw
Copy link
Contributor Author

Fixed the review comments.

amarzavery added a commit that referenced this pull request Feb 26, 2016
Graph swagger specs for version 1.6-internal
@amarzavery amarzavery merged commit 8688133 into Azure:master Feb 26, 2016
hyonholee pushed a commit to hyonholee/azure-rest-api-specs that referenced this pull request Sep 22, 2017
Add rolling upgrade API for VM Scale Set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants