Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Management Control Plane Swagger - Direct Route - First Version #2202

Closed
wants to merge 2 commits into from

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Jan 2, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@solankisamir solankisamir changed the title API Management Data Plane SDK - First Version API Management Data Plane Swagger - First Version Jan 2, 2018
- Microsoft.ApiManagement/preview/2017-03-01/apimgroups.json
- Microsoft.ApiManagement/preview/2017-03-01/apimidentityprovider.json
- Microsoft.ApiManagement/preview/2017-03-01/apimloggers.json
- Microsoft.ApiManagement/preview/2017-03-01/apimnetworkstatus.json
Copy link
Contributor

@sergey-shandar sergey-shandar Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft.ApiManagement/preview/2017-03-01/apimnetworkstatus.json is missing.

Copy link
Member Author

@solankisamir solankisamir Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#Fixed. Good catch. It was not needed.

@solankisamir
Copy link
Member Author

@sergey-shandar ping on this.

@solankisamir solankisamir changed the title API Management Data Plane Swagger - First Version API Management Control Plane Swagger - Direct Route - First Version Jan 5, 2018
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/apimanagement/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 96

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Copy link
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, provide examples to all operations.

"format": "date-time",
"description": "The date of the end of Counter Period. The date conforms to the following format: `yyyy-MM-ddTHH:mm:ssZ` as specified by the ISO 8601 standard.\n"
},
"Value": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name Value should follow camelCase style, for example value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is being fixed in next api-version #1987

@sergey-shandar
Copy link
Contributor

@solankisamir Could you provide examples for the specs?

@solankisamir
Copy link
Member Author

@sergey-shandar working on examples

@solankisamir
Copy link
Member Author

closing the pull request and opening a new one with multiple changes.

@AutorestCI
Copy link

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

@sergey-shandar
Copy link
Contributor

@solankisamir please, add a link to the new PR so we can track and understand context. It will also help reviewers to see if it's partially reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants