-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Management Control Plane Swagger - Direct Route - First Version #2202
Conversation
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
- Microsoft.ApiManagement/preview/2017-03-01/apimgroups.json | ||
- Microsoft.ApiManagement/preview/2017-03-01/apimidentityprovider.json | ||
- Microsoft.ApiManagement/preview/2017-03-01/apimloggers.json | ||
- Microsoft.ApiManagement/preview/2017-03-01/apimnetworkstatus.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Microsoft.ApiManagement/preview/2017-03-01/apimnetworkstatus.json
is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#Fixed. Good catch. It was not needed.
@sergey-shandar ping on this. |
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, provide examples to all operations.
"format": "date-time", | ||
"description": "The date of the end of Counter Period. The date conforms to the following format: `yyyy-MM-ddTHH:mm:ssZ` as specified by the ISO 8601 standard.\n" | ||
}, | ||
"Value": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name Value
should follow camelCase style, for example value
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue is being fixed in next api-version #1987
@solankisamir Could you provide examples for the specs? |
@sergey-shandar working on examples |
closing the pull request and opening a new one with multiple changes. |
Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR. |
@solankisamir please, add a link to the new PR so we can track and understand context. It will also help reviewers to see if it's partially reviewed. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
Quality of Swagger