Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADF] Swagger Change for Responsys Source #2735

Merged
merged 1 commit into from
Mar 28, 2018
Merged

[ADF] Swagger Change for Responsys Source #2735

merged 1 commit into from
Mar 28, 2018

Conversation

ninishaha
Copy link
Contributor

@ninishaha ninishaha commented Mar 22, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

dsgouda
dsgouda suggested changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part

...urce-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/LinkedService.json
"ResponsysLinkedServiceTypeProperties": {
"description": "Responsys linked service properties.",
"properties": {
"endpoint": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please check which of these properties should be marked readonly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep align with other ODBC connectors. BTW, how can it be marked as read only?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an example

...urce-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/LinkedService.json
"$ref": "#/definitions/ResponsysLinkedServiceTypeProperties"
}
},
"required": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the examples if any

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing should be updated in example since we just added a new connector.

dsgouda
dsgouda approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 12856c1 into Azure:master Mar 28, 2018
@AutorestCI AutorestCI mentioned this pull request Mar 28, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 28, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2293

@AutorestCI AutorestCI mentioned this pull request Mar 28, 2018
Open
@AutorestCI
Copy link

AutorestCI commented Mar 28, 2018 •
edited
Loading

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#18

@AutorestCI AutorestCI mentioned this pull request Mar 28, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 28, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1460

@AutorestCI AutorestCI mentioned this pull request Mar 28, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 28, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ninishaha @AutorestCI @dsgouda @shelfeng-ms