Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHub: removed messaging plan from namespace #2807

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

v-Ajnava
Copy link
Member

@v-Ajnava v-Ajnava commented Apr 4, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Apr 4, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2051

@AutorestCI
Copy link

AutorestCI commented Apr 4, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2658

@AutorestCI
Copy link

AutorestCI commented Apr 4, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#53

@AutorestCI
Copy link

AutorestCI commented Apr 4, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1506

@anuchandy anuchandy self-requested a review April 4, 2018 18:29
@anuchandy
Copy link
Member

@lmazuel assigned myself as one of the reviewer. I had an email conversation with @v-Ajnava and @arundsouza . Exposing this endpoint was an error in the swagger, the MessagingPlan data is already available in namespace resource. Service team will not expose this api in future api versions as well.

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anu says it's fine, then it's fine ;)

@lmazuel lmazuel merged commit b5e8859 into Azure:master Apr 4, 2018
@anuchandy
Copy link
Member

@lmazuel thanks!

v-Ajnava pushed a commit to v-Ajnava/azure-rest-api-specs that referenced this pull request Apr 10, 2018
hovsepm pushed a commit that referenced this pull request Apr 10, 2018
…#2846)

* Revert "remove messaging plan from namespace (#2807)"

This reverts commit b5e8859.

* Updated MessagingPlan, Regions, examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants